-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply API review fixes for MTROTAHeaderParser. #23479
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-reland-PR-22611
Nov 3, 2022
Merged
Apply API review fixes for MTROTAHeaderParser. #23479
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-reland-PR-22611
Nov 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a re-landing of PR project-chip#22611 but with changes made for backwards compat. * Move the parsing method to MTROTAHeader. * Rename the file to MTROTAHeader.h * Add documentation.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
msandstedt
November 3, 2022 19:42
pullapprove
bot
requested review from
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 3, 2022 19:42
pullapprove
bot
added
review - pending
darwin
examples
and removed
examples
darwin
labels
Nov 3, 2022
PR #23479: Size comparison from 548da8b to 42fa20e Increases (2 builds for bl602, bl702)
Decreases (1 build for bl602)
Full report (7 builds for bl602, bl702, k32w)
|
jtung-apple
approved these changes
Nov 3, 2022
Fast-tracking platform-specific fix with platform owner review. |
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22611 but with changes made for backwards compat. * Move the parsing method to MTROTAHeader. * Rename the file to MTROTAHeader.h * Add documentation.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22611 but with changes made for backwards compat. * Move the parsing method to MTROTAHeader. * Rename the file to MTROTAHeader.h * Add documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-landing of PR #22611 but with changes made for backwards compat.