Darwin: Improve os_log integration #23528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #23528: Size comparison from b278e34 to 8920efe Decreases (2 builds for bl602)
Full report (2 builds for bl602)
|
ksperling-apple
force-pushed
the
logging-improvements
branch
from
8920efe to
fede0e4
Compare
|
PR #23528: Size comparison from 94ad961 to fede0e4 Decreases (2 builds for bl602)
Full report (2 builds for bl602)
|
ksperling-apple
force-pushed
the
logging-improvements
branch
from
fede0e4 to
6637c61
Compare
|
PR #23528: Size comparison from fe9a8ec to 6637c61 Increases above 0.2%:
Increases (26 builds for bl702, cc13x2_26x2, cyw30739, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (24 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
cliffamzn
reviewed
Nov 17, 2022
ksperling-apple
force-pushed
the
logging-improvements
branch
from
6637c61 to
872b532
Compare
|
PR #23528: Size comparison from 3198f01 to 872b532 Increases above 0.2%:
Increases (27 builds for bl702, cc13x2_26x2, cyw30739, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (25 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
ksperling-apple
force-pushed
the
logging-improvements
branch
2 times, most recently
from
77cdeb7 to
77ff5ef
Compare
|
PR #23528: Size comparison from 669cd47 to 77ff5ef Increases above 0.2%:
Increases (10 builds for bl702, k32w, linux, mbed, nrfconnect, qpg)
Decreases (11 builds for bl602, bl702, nrfconnect, telink)
Full report (19 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
ksperling-apple
force-pushed
the
logging-improvements
branch
from
77ff5ef to
21018f8
Compare
|
PR #23528: Size comparison from 669cd47 to 21018f8 Increases above 0.2%:
Increases (25 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (27 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, nrfconnect, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #23528: Size comparison from 669cd47 to e8f9f14 Increases above 0.2%:
Increases (31 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (27 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, nrfconnect, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ksperling-apple
force-pushed
the
logging-improvements
branch
from
e8f9f14 to
f6478c8
Compare
|
PR #23528: Size comparison from 669cd47 to f6478c8 Increases above 0.2%:
Increases (31 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (28 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 30, 2022
…ING to CHIPConfig.h
Introduce CHIP_SYSTEM_CONFIG_PLATFORM_LOG that enables integrating with CHIP logging at the log macro level. Note: ChipLog* macros are now statements (not expressions), so a few of usages of VerifyOr... macros required adjustments.
…m logging backend and use it for unit tests and cli tools (chip-tool etc)
…TRLogging_Internal.h. Also compile all ObjC files as ObjC++.
ksperling-apple
force-pushed
the
logging-improvements
branch
from
514cf83 to
9c149d0
Compare
jmartinez-silabs
approved these changes
Dec 1, 2022
|
PR #23528: Size comparison from 380d403 to 9c149d0 Increases above 0.2%:
Increases (44 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (27 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible for platform code to directly wrap the
ChipLog*macros, and utilises this on Darwin to log directly intoos_log(the CHIP LogV method is still called to allow log redirection to work). This has a number of advantages over the existing Platform LogV based implementation:os_loglog level.With this change, logging on Mac also no longer always goes to stdout. Where log output on stdout is desired (unit tests, chip-tool etc), the
stdiobackend is linked into the relevant targets. For darwin-framework-tool this is implemented using the Log redirection mechanism which is now also exposed in the Darwin framework.