-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused python-dbus #23564
Merged
andy31415
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/remove-python-dbus
Nov 14, 2022
Merged
remove unused python-dbus #23564
andy31415
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/remove-python-dbus
Nov 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23564: Size comparison from fe7d3fe to 5835c51 Increases (4 builds for esp32, nrfconnect, psoc6)
Decreases (5 builds for bl602, bl702, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 10, 2022
arkq
approved these changes
Nov 10, 2022
PR #23564: Size comparison from fe7d3fe to 98899b3 Increases (3 builds for cc13x2_26x2, esp32, nrfconnect)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 10, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* remove unused python-dbus * Restyled by gn Co-authored-by: Restyled.io <commits@restyled.io>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* remove unused python-dbus * Restyled by gn Co-authored-by: Restyled.io <commits@restyled.io>
This was referenced Feb 14, 2023
agners
added a commit
to agners/connectedhomeip
that referenced
this pull request
Feb 14, 2023
Move BlueZ and CoreBluetooth classes and its dependencies to the chip-repl package. This removes dependencies from the chip-core wheel and also makes sure that all dependencies are present for BlueZ (including python-dbus). It partially reverts remove unused python-dbus (project-chip#23564).
woody-apple
pushed a commit
that referenced
this pull request
Feb 14, 2023
* [python] move BlueZ/CoreBluetooth to chip-repl package Move BlueZ and CoreBluetooth classes and its dependencies to the chip-repl package. This removes dependencies from the chip-core wheel and also makes sure that all dependencies are present for BlueZ (including python-dbus). It partially reverts remove unused python-dbus (#23564). * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io>
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…25055) * [python] move BlueZ/CoreBluetooth to chip-repl package Move BlueZ and CoreBluetooth classes and its dependencies to the chip-repl package. This removes dependencies from the chip-core wheel and also makes sure that all dependencies are present for BlueZ (including python-dbus). It partially reverts remove unused python-dbus (project-chip#23564). * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-dbus was used when we do python controller with python bluez implementation, now we have switched to c++ bluez implemenation, so we can remove this python-dbus