-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] Enable WiFi management from example app #23633
Conversation
375c859
to
084eef8
Compare
PR #23633: Size comparison from 8c09eae to 084eef8 Increases (9 builds for bl702, esp32, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
084eef8
to
301ba1c
Compare
PR #23633: Size comparison from e241184 to 301ba1c Increases (12 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (1 build for cc13x2_26x2)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
The IsWiFiManagementStarted is used by the example Linux applications to check whether CHIP applications is connected with wpa_supplicant WiFi manager. Since Tizen examples are based on Linux code and Tizen uses wpa_supplicant as well, Tizen should also implement such check function.
301ba1c
to
007df71
Compare
PR #23633: Size comparison from 770e39c to 007df71 Full report (2 builds for cc32xx, mbed)
|
PR #23633: Size comparison from 770e39c to 9ec5a1b Increases above 0.2%:
Increases (25 builds for bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for bl602, cc13x2_26x2)
Full report (41 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
I've tested these changes with the Lightapp on Tizen and chip-tool on Linux. Everything worked as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [Tizen] Simplify WiFiManager::IsActivated usage * Apply clang-tidy modernize-redundant-void-arg * Fix incorrect feature flag for enabling WiFi * [Tizen] Implement WiFi started check function The IsWiFiManagementStarted is used by the example Linux applications to check whether CHIP applications is connected with wpa_supplicant WiFi manager. Since Tizen examples are based on Linux code and Tizen uses wpa_supplicant as well, Tizen should also implement such check function. * Activate/deactivate WiFi without async wrapper * Add network.set privilege required for WiFi management * Fix compilation failure after syncing with master
Problem
Tizen examples are based on Linux code. Tizen and Linux are using wpa_supplicant for WiFi management. In Linux example code, WiFi feature is controlled by
CHIP_DEVICE_CONFIG_ENABLE_WPA
feature flag, however, Tizen configuration does not. In order to properly support WiFi management Tizen needs to useCHIP_DEVICE_CONFIG_ENABLE_WPA
as well and needs to implement missing functions.Changes
WiFiManager::IsActivated()
usage (reuse it in other functions)Testing
CI will check potential build failures. Tizen WiFi functionality was tested with Tizen lighting-all: