Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nordic factory data did not validate rd_uid field properly #23660

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Nordic factory data did not validate rd_uid field properly #23660

merged 1 commit into from
Nov 21, 2022

Conversation

markus-becker-tridonic-com
Copy link
Contributor

Nordic factory data did not validate rd_uid field.

  • minLength was duplicated, was clearly maxLength.
  • the length in pattern was wrong. minimum 128 bit = 16 byte = 32 hex chars (+ 4 chars for "hex:"). maximum double of the minimum.

FYI: @Damian-Nordic

Damian-Nordic
Damian-Nordic approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited
Loading

PR #23660: Size comparison from 80f7dcd to c80f7f4

Increases (5 builds for bl602, cc13x2_26x2, nrfconnect, telink)
platform target config section 80f7dcd c80f7f4 change % change
bl602 lighting-app bl602 .text 1059786 1059788 2 0.0
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 673411 673419 8 0.0
.text 586584 586592 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 817328 817332 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167659 1167675 16 0.0
text 805878 805882 4 0.0
telink all-clusters-app tlsr9518adk80d text 649088 649090 2 0.0
Decreases (6 builds for bl702, cc13x2_26x2, psoc6, telink)
platform target config section 80f7dcd c80f7f4 change % change
bl702 lighting-app bl702 .debug_info 39163806 39163805 -1 -0.0
.text 956048 956046 -2 -0.0
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 176524 176516 -8 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22229530 22229529 -1 -0.0
telink all-clusters-minimal-app tlsr9518adk80d text 613076 613074 -2 -0.0
light-switch-app tlsr9518adk80d text 554538 554536 -2 -0.0
ota-requestor-app tlsr9518adk80d text 565918 565916 -2 -0.0
Full report (59 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 80f7dcd c80f7f4 change % change
bl602 lighting-app bl602 (read/write) 1375978 1375978 0 0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1059786 1059788 2 0.0
bl602+rpc (read/write) 1421802 1421802 0 0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1091282 1091282 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195783 1195783 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1524128 1524128 0 0.0
.debug_aranges 132328 132328 0 0.0
.debug_frame 485344 485344 0 0.0
.debug_info 39163806 39163805 -1 -0.0
.debug_line 5273525 5273525 0 0.0
.debug_loc 3368511 3368511 0 0.0
.debug_ranges 360464 360464 0 0.0
.debug_str 3463616 3463616 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116616 116616 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 566910 566910 0 0.0
.symtab 171888 171888 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956048 956046 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283923 1283923 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1668158 1668158 0 0.0
.debug_aranges 140392 140392 0 0.0
.debug_frame 512548 512548 0 0.0
.debug_info 4343300 4343300 0 0.0
.debug_line 5668894 5668894 0 0.0
.debug_loc 3562746 3562746 0 0.0
.debug_ranges 383488 383488 0 0.0
.debug_str 3860931 3860931 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130232 130232 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 627125 627125 0 0.0
.symtab 190000 190000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029746 1029746 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678459 678459 0 0.0
(read/write) 173076 173076 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89851 89851 0 0.0
.text 588296 588296 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642755 642755 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78987 78987 0 0.0
.text 563448 563448 0 0.0
lock-ftd LP_CC2652R7 (read only) 676599 676599 0 0.0
(read/write) 172504 172504 0 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77271 77271 0 0.0
.text 598848 598848 0 0.0
lock-mtd LP_CC2652R7 (read only) 661203 661203 0 0.0
(read/write) 183156 183156 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103355 103355 0 0.0
.text 557368 557368 0 0.0
pump-app LP_CC2652R7 (read only) 689135 689135 0 0.0
(read/write) 160704 160704 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90799 90799 0 0.0
.text 597852 597852 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673411 673419 8 0.0
(read/write) 176524 176516 -8 -0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86347 86347 0 0.0
.text 586584 586592 8 0.0
shell LP_CC2652R7 (read only) 669678 669678 0 0.0
(read/write) 184176 184176 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86598 86598 0 0.0
.text 582764 582764 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587526 587526 0 0.0
.app_xip_area 463736 463736 0 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591634 591634 0 0.0
.app_xip_area 462548 462548 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544010 544010 0 0.0
.app_xip_area 425740 425740 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974580 974580 0 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 820132 820132 0 0.0
BRD4161A+rs911x (read/write) 1035368 1035368 0 0.0
.bss 186736 186736 0 0.0
.data 2012 2012 0 0.0
.text 846596 846596 0 0.0
BRD4187C (read/write) 1147176 1147176 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 981408 981408 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160560 1160560 0 0.0
.bss 158264 158264 0 0.0
.data 2020 2020 0 0.0
.text 1000252 1000252 0 0.0
window-app BRD4187C (read/write) 1140396 1140396 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 973188 973188 0 0.0
esp32 all-clusters-app c3devkit (read only) 1213516 1213516 0 0.0
(read/write) 1786574 1786574 0 0.0
.dram0.bss 76680 76680 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 256400 256400 0 0.0
.flash.text 1213516 1213516 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1224391 1224391 0 0.0
(read/write) 562540 562540 0 0.0
.dram0.bss 82056 82056 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 313520 313520 0 0.0
.flash.text 1219007 1219007 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662084 662084 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 563756 563756 0 0.0
light k32w0+release (read/write) 672176 672176 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 592476 592476 0 0.0
lock k32w0+release (read/write) 633644 633644 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 553164 553164 0 0.0
linux all-clusters-app debug (read only) 3077625 3077625 0 0.0
(read/write) 158472 158472 0 0.0
.bss 62464 62464 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 87144 87144 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281323 281323 0 0.0
.text 2611810 2611810 0 0.0
all-clusters-minimal-app debug (read only) 2903321 2903321 0 0.0
(read/write) 149872 149872 0 0.0
.bss 61664 61664 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280811 280811 0 0.0
.text 2441058 2441058 0 0.0
bridge-app debug+rpc (read only) 2402241 2402241 0 0.0
(read/write) 129608 129608 0 0.0
.bss 51008 51008 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68776 68776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 210976 210976 0 0.0
.text 2023906 2023906 0 0.0
chip-tool debug (read only) 11071265 11071265 0 0.0
(read/write) 658464 658464 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 623200 623200 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 592165 592165 0 0.0
.text 8955396 8955396 0 0.0
chip-tool-ipv6only arm64 (read only) 10424780 10424780 0 0.0
(read/write) 706529 706529 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650832 650832 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518428 518428 0 0.0
.text 8250564 8250564 0 0.0
lighting-app debug+rpc (read only) 2633297 2633297 0 0.0
(read/write) 132456 132456 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73992 73992 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227872 227872 0 0.0
.text 2228722 2228722 0 0.0
lock-app debug (read only) 2592521 2592521 0 0.0
(read/write) 127376 127376 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70840 70840 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244168 244168 0 0.0
.text 2176642 2176642 0 0.0
ota-provider-app debug (read only) 2388689 2388689 0 0.0
(read/write) 120904 120904 0 0.0
.bss 47936 47936 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64760 64760 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 216648 216648 0 0.0
.text 2003490 2003490 0 0.0
ota-requestor-app debug (read only) 2553953 2553953 0 0.0
(read/write) 129248 129248 0 0.0
.bss 50464 50464 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 70120 70120 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 223728 223728 0 0.0
.text 2152578 2152578 0 0.0
shell debug (read only) 2614817 2614817 0 0.0
(read/write) 142968 142968 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78040 78040 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239538 239538 0 0.0
.text 2215762 2215762 0 0.0
thermostat-no-ble arm64 (read only) 2384124 2384124 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144996 144996 0 0.0
.text 1995232 1995232 0 0.0
tv-app debug (read only) 3246977 3246977 0 0.0
(read/write) 261992 261992 0 0.0
.bss 170648 170648 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80384 80384 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268568 268568 0 0.0
.text 2784418 2784418 0 0.0
tv-casting-app debug (read only) 5573009 5573009 0 0.0
(read/write) 161880 161880 0 0.0
.bss 52120 52120 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101216 101216 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 355353 355353 0 0.0
.text 4941986 4941986 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452672 2452672 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1415316 1415316 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188243 1188243 0 0.0
bss 145285 145285 0 0.0
rodata 144552 144552 0 0.0
text 817328 817332 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167659 1167675 16 0.0
bss 144512 144512 0 0.0
rodata 136344 136344 0 0.0
text 805878 805882 4 0.0
light-switch-app nrf52840dk_nrf52840 (read/write) 1100391 1100391 0 0.0
bss 136891 136891 0 0.0
rodata 121708 121708 0 0.0
text 760746 760746 0 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 1149103 1149103 0 0.0
bss 148073 148073 0 0.0
rodata 116788 116788 0 0.0
text 801934 801934 0 0.0
nrf52840dongle_nrf52840 (read/write) 1086271 1086271 0 0.0
bss 154334 154334 0 0.0
rodata 94460 94460 0 0.0
text 753144 753144 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1080814 1080814 0 0.0
bss 143016 143016 0 0.0
rodata 118000 118000 0 0.0
text 736716 736716 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1133995 1133995 0 0.0
bss 137896 137896 0 0.0
rodata 143240 143240 0 0.0
text 771956 771956 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1036650 1036650 0 0.0
bss 133781 133781 0 0.0
rodata 135644 135644 0 0.0
text 684142 684142 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1089275 1089275 0 0.0
bss 136720 136720 0 0.0
rodata 118976 118976 0 0.0
text 752538 752538 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1075599 1075599 0 0.0
bss 136487 136487 0 0.0
rodata 115460 115460 0 0.0
text 742636 742636 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1746868 1746868 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235876 1235876 0 0.0
.debug_aranges 110728 110728 0 0.0
.debug_frame 371396 371396 0 0.0
.debug_info 27027690 27027690 0 0.0
.debug_line 3687746 3687746 0 0.0
.debug_loc 3606504 3606504 0 0.0
.debug_ranges 340032 340032 0 0.0
.debug_str 3432511 3432511 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570636 570636 0 0.0
.symtab 421600 421600 0 0.0
.text 1547104 1547104 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1689404 1689404 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227719 1227719 0 0.0
.debug_aranges 110200 110200 0 0.0
.debug_frame 374476 374476 0 0.0
.debug_info 26764320 26764320 0 0.0
.debug_line 3708730 3708730 0 0.0
.debug_loc 3594110 3594110 0 0.0
.debug_ranges 338648 338648 0 0.0
.debug_str 3421531 3421531 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534725 534725 0 0.0
.symtab 408032 408032 0 0.0
.text 1490376 1490376 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1607564 1607564 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062180 1062180 0 0.0
.debug_aranges 102400 102400 0 0.0
.debug_frame 344788 344788 0 0.0
.debug_info 22229530 22229529 -1 -0.0
.debug_line 3277857 3277857 0 0.0
.debug_loc 3291595 3291595 0 0.0
.debug_ranges 303928 303928 0 0.0
.debug_str 3227066 3227066 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 471050 471050 0 0.0
.symtab 376400 376400 0 0.0
.text 1416720 1416720 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1641588 1641588 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064155 1064155 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346664 346664 0 0.0
.debug_info 22463155 22463155 0 0.0
.debug_line 3274977 3274977 0 0.0
.debug_loc 3319448 3319448 0 0.0
.debug_ranges 305888 305888 0 0.0
.debug_str 3246423 3246423 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473453 473453 0 0.0
.symtab 378096 378096 0 0.0
.text 1445752 1445752 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151184 1151184 0 0.0
.bss 111116 111116 0 0.0
.data 848 848 0 0.0
.text 598284 598284 0 0.0
lock-app qpg6105+debug (read/write) 1116880 1116880 0 0.0
.bss 106564 106564 0 0.0
.data 836 836 0 0.0
.text 563976 563976 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937800 937800 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 649088 649090 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 875792 875792 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 613076 613074 -2 -0.0
light-switch-app tlsr9518adk80d (read/write) 791148 791148 0 0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 554538 554536 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 875372 875372 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 624500 624500 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 805640 805640 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 565918 565916 -2 -0.0

@bzbarsky-apple
Copy link
Contributor

@markus-becker-tridonic-com restyle failures?

@markus-becker-tridonic-com
Copy link
Contributor Author

markus-becker-tridonic-com commented Nov 18, 2022 •
edited
Loading

@markus-becker-tridonic-com restyle failures?

Looks like a timeout issue of the restyled job.

@markus-becker-tridonic-com
rd_uid did not validate
5b67386 
* minLength was duplicated, was clearly maxLength.
* the length in pattern was wrong. minimum 128 bit = 16 byte = 32 hex chars. maximum double of the minimum.
@github-actions
Copy link

github-actions bot commented Nov 21, 2022 •
edited
Loading

PR #23660: Size comparison from 494f5f5 to 5b67386

Increases (10 builds for bl602, bl702, cyw30739, esp32, nrfconnect, psoc6, telink)
platform target config section 494f5f5 5b67386a change % change
bl602 lighting-app bl602 (read/write) 1377446 1377454 8 0.0
.text 1061182 1061186 4 0.0
bl602+rpc (read/write) 1423310 1423318 8 0.0
.text 1092656 1092658 2 0.0
bl702 lighting-app bl702 .debug_info 39158234 39158235 1 0.0
.text 957188 957190 2 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588438 588446 8 0.0
.app_xip_area 464648 464656 8 0.0
esp32 all-clusters-app m5stack (read/write) 562636 562644 8 0.0
.flash.rodata 313608 313616 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 806932 806936 4 0.0
lock-app nrf52840dk_nrf52840 text 772702 772706 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27020981 27020983 2 0.0
lock cy8ckit_062s2_43012 .debug_info 22446758 22446759 1 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 939068 939076 8 0.0
text 650282 650286 4 0.0
Decreases (7 builds for cyw30739, esp32, nrfconnect, psoc6, telink)
platform target config section 494f5f5 5b67386a change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544810 544802 -8 -0.0
.app_xip_area 426540 426532 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1214664 1214662 -2 -0.0
(read/write) 1786670 1786662 -8 -0.0
.flash.rodata 256496 256488 -8 -0.0
.flash.text 1214664 1214662 -2 -0.0
nrfconnect pump-app nrf52840dk_nrf52840 text 753620 753616 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1076599 1076583 -16 -0.0
text 743386 743382 -4 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22227200 22227199 -1 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 792000 791992 -8 -0.0
text 555312 555308 -4 -0.0
lighting-app tlsr9518adk80d text 625626 625624 -2 -0.0
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 494f5f5 5b67386a change % change
bl602 lighting-app bl602 (read/write) 1377446 1377454 8 0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1061182 1061186 4 0.0
bl602+rpc (read/write) 1423310 1423318 8 0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1092656 1092658 2 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1196999 1196999 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1524244 1524244 0 0.0
.debug_aranges 132384 132384 0 0.0
.debug_frame 485640 485640 0 0.0
.debug_info 39158234 39158235 1 0.0
.debug_line 5276300 5276300 0 0.0
.debug_loc 3373203 3373203 0 0.0
.debug_ranges 361240 361240 0 0.0
.debug_str 3474842 3474842 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116680 116680 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568313 568313 0 0.0
.symtab 172032 172032 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957188 957190 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1285539 1285539 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1668414 1668414 0 0.0
.debug_aranges 140480 140480 0 0.0
.debug_frame 512976 512976 0 0.0
.debug_info 43429604 43429604 0 0.0
.debug_line 5673694 5673694 0 0.0
.debug_loc 3567814 3567814 0 0.0
.debug_ranges 384760 384760 0 0.0
.debug_str 3872439 3872439 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130424 130424 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 628463 628463 0 0.0
.symtab 190176 190176 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031170 1031170 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679603 679603 0 0.0
(read/write) 171932 171932 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89923 89923 0 0.0
.text 589368 589368 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643859 643859 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 79059 79059 0 0.0
.text 564480 564480 0 0.0
lock-ftd LP_CC2652R7 (read only) 677295 677295 0 0.0
(read/write) 171808 171808 0 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77351 77351 0 0.0
.text 599464 599464 0 0.0
lock-mtd LP_CC2652R7 (read only) 661995 661995 0 0.0
(read/write) 182364 182364 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103435 103435 0 0.0
.text 558080 558080 0 0.0
pump-app LP_CC2652R7 (read only) 690167 690167 0 0.0
(read/write) 159672 159672 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90871 90871 0 0.0
.text 598812 598812 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674139 674139 0 0.0
(read/write) 175796 175796 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86427 86427 0 0.0
.text 587232 587232 0 0.0
shell LP_CC2652R7 (read only) 670822 670822 0 0.0
(read/write) 183032 183032 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86670 86670 0 0.0
.text 583836 583836 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588438 588446 8 0.0
.app_xip_area 464648 464656 8 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592210 592210 0 0.0
.app_xip_area 463124 463124 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544810 544802 -8 -0.0
.app_xip_area 426540 426532 -8 -0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 975820 975820 0 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 821372 821372 0 0.0
BRD4161A+rs911x (read/write) 1036720 1036720 0 0.0
.bss 186736 186736 0 0.0
.data 2012 2012 0 0.0
.text 847948 847948 0 0.0
BRD4187C (read/write) 1148544 1148544 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 982776 982776 0 0.0
lock-app BRD4161A+wf200 (read/write) 1161360 1161360 0 0.0
.bss 158264 158264 0 0.0
.data 2020 2020 0 0.0
.text 1001052 1001052 0 0.0
window-app BRD4187C (read/write) 1141268 1141268 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 974060 974060 0 0.0
esp32 all-clusters-app c3devkit (read only) 1214664 1214662 -2 -0.0
(read/write) 1786670 1786662 -8 -0.0
.dram0.bss 76688 76688 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 256496 256488 -8 -0.0
.flash.text 1214664 1214662 -2 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1225427 1225427 0 0.0
(read/write) 562636 562644 8 0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 313608 313616 8 0.0
.flash.text 1220043 1220043 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662724 662724 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564396 564396 0 0.0
light k32w0+release (read/write) 673256 673256 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 593556 593556 0 0.0
lock k32w0+release (read/write) 634284 634284 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 553804 553804 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10447340 10447340 0 0.0
(read/write) 707697 707697 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 651984 651984 0 0.0
.dynamic 560 560 0 0.0
.got 13944 13944 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 519292 519292 0 0.0
.text 8269476 8269476 0 0.0
thermostat-no-ble arm64 (read only) 2387012 2387012 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 145068 145068 0 0.0
.text 1998048 1998048 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453656 2453656 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1416300 1416300 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1189583 1189583 0 0.0
bss 145285 145285 0 0.0
rodata 144804 144804 0 0.0
text 818414 818414 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1168963 1168963 0 0.0
bss 144512 144512 0 0.0
rodata 136592 136592 0 0.0
text 806932 806936 4 0.0
light-switch-app nrf52840dk_nrf52840 (read/write) 1101411 1101411 0 0.0
bss 136891 136891 0 0.0
rodata 121960 121960 0 0.0
text 761510 761510 0 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 1150563 1150563 0 0.0
bss 148073 148073 0 0.0
rodata 117096 117096 0 0.0
text 803088 803088 0 0.0
nrf52840dongle_nrf52840 (read/write) 1087607 1087607 0 0.0
bss 154334 154334 0 0.0
rodata 94708 94708 0 0.0
text 754230 754230 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1082154 1082154 0 0.0
bss 143016 143016 0 0.0
rodata 118252 118252 0 0.0
text 737798 737798 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1134999 1134999 0 0.0
bss 137896 137896 0 0.0
rodata 143492 143492 0 0.0
text 772702 772706 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1037738 1037738 0 0.0
bss 133793 133793 0 0.0
rodata 135924 135924 0 0.0
text 684908 684908 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1090599 1090599 0 0.0
bss 136720 136720 0 0.0
rodata 119228 119228 0 0.0
text 753620 753616 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1076599 1076583 -16 -0.0
bss 136487 136487 0 0.0
rodata 115708 115708 0 0.0
text 743386 743382 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1748228 1748228 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235661 1235661 0 0.0
.debug_aranges 110744 110744 0 0.0
.debug_frame 371588 371588 0 0.0
.debug_info 27020981 27020983 2 0.0
.debug_line 3691677 3691677 0 0.0
.debug_loc 3616499 3616499 0 0.0
.debug_ranges 341008 341008 0 0.0
.debug_str 3444213 3444213 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571950 571950 0 0.0
.symtab 421904 421904 0 0.0
.text 1548464 1548464 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1690748 1690748 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227552 1227552 0 0.0
.debug_aranges 110216 110216 0 0.0
.debug_frame 374668 374668 0 0.0
.debug_info 26758664 26758664 0 0.0
.debug_line 3712661 3712661 0 0.0
.debug_loc 3604105 3604105 0 0.0
.debug_ranges 339624 339624 0 0.0
.debug_str 3433225 3433225 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536039 536039 0 0.0
.symtab 408336 408336 0 0.0
.text 1491720 1491720 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1608924 1608924 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062079 1062079 0 0.0
.debug_aranges 102416 102416 0 0.0
.debug_frame 344980 344980 0 0.0
.debug_info 22227200 22227199 -1 -0.0
.debug_line 3281782 3281782 0 0.0
.debug_loc 3301540 3301540 0 0.0
.debug_ranges 304904 304904 0 0.0
.debug_str 3238811 3238811 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472364 472364 0 0.0
.symtab 376704 376704 0 0.0
.text 1418080 1418080 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1642436 1642436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064054 1064054 0 0.0
.debug_aranges 102816 102816 0 0.0
.debug_frame 346832 346832 0 0.0
.debug_info 22446758 22446759 1 0.0
.debug_line 3276610 3276610 0 0.0
.debug_loc 3323117 3323117 0 0.0
.debug_ranges 306288 306288 0 0.0
.debug_str 3255068 3255068 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474151 474151 0 0.0
.symtab 378368 378368 0 0.0
.text 1446600 1446600 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1152208 1152208 0 0.0
.bss 111116 111116 0 0.0
.data 848 848 0 0.0
.text 599308 599308 0 0.0
lock-app qpg6105+debug (read/write) 1117640 1117640 0 0.0
.bss 106564 106564 0 0.0
.data 836 836 0 0.0
.text 564736 564736 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 939068 939076 8 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 650282 650286 4 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 877036 877036 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 614240 614240 0 0.0
light-switch-app tlsr9518adk80d (read/write) 792000 791992 -8 -0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 555312 555308 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 876576 876576 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 625626 625624 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 806468 806468 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 566672 566672 0 0.0

@Damian-Nordic Damian-Nordic merged commit 4c6b72d into project-chip:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markus-becker-tridonic-com @bzbarsky-apple @andy31415 @Damian-Nordic