-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for substituting YAML value to global config variables #23743
Merged
jmartinez-silabs
merged 4 commits into
project-chip:master
from
tehampson:config-value-substitution
Nov 29, 2022
Merged
Allow for substituting YAML value to global config variables #23743
jmartinez-silabs
merged 4 commits into
project-chip:master
from
tehampson:config-value-substitution
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
rgoliver
November 24, 2022 01:33
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
November 24, 2022 01:33
PR #23743: Size comparison from 7f1b4b8 to 4944ac4 Increases (7 builds for bl602, cc13x2_26x2, efr32, psoc6, qpg, telink)
Decreases (7 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Full report (41 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Nov 24, 2022
PR #23743: Size comparison from 7f1b4b8 to 0bda4ea Increases (14 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, psoc6, telink)
Decreases (12 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, nrfconnect, telink)
Full report (41 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23743: Size comparison from 733afaa to 0936858 Increases (6 builds for cc13x2_26x2, efr32, esp32, psoc6, telink)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, efr32, psoc6, telink)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a value substitution method when parsing YAML values that allows for globally configured variables to be properly used in the various test cases.
Tested inside chip-repl with the following commands (with all-cluster app running on separate terminal already commissioned). Confirmed there was an improvement in overall test coverage: