Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NS_ASSUME_NONNULL_BEGIN to MTRCallbackBridgeBase_internal. #23849

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Add NS_ASSUME_NONNULL_BEGIN to MTRCallbackBridgeBase_internal. #23849

merged 1 commit into from
Dec 1, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

This way we can explicitly annotate which bits might be null.

For some of the block pointers we apparently need to explicitly specify _Nonnull even with NS_ASSUME_NONNULL_BEGIN. Maybe because of the templating involved.

@bzbarsky-apple
Add NS_ASSUME_NONNULL_BEGIN to MTRCallbackBridgeBase_internal.
fb96fbe 
This way we can explicitly annotate which bits might be null.

For some of the block pointers we apparently need to explicitly specify _Nonnull
even with NS_ASSUME_NONNULL_BEGIN.  Maybe because of the templating involved.
@github-actions github-actions bot added the darwin label Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 1, 2022 •
edited
Loading

PR #23849: Size comparison from 7431dc2 to fb96fbe

Increases (2 builds for esp32, nrfconnect)
platform target config section 7431dc2 fb96fbe change % change
esp32 all-clusters-app m5stack (read/write) 562668 562676 8 0.0
.flash.rodata 313640 313648 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 790028 790032 4 0.0
Decreases (5 builds for psoc6, telink)
platform target config section 7431dc2 fb96fbe change % change
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26760899 26760898 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22447317 22447316 -1 -0.0
telink light-switch-app tlsr9518adk80d text 555330 555328 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 876516 876508 -8 -0.0
text 625574 625572 -2 -0.0
ota-requestor-app tlsr9518adk80d text 566670 566668 -2 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 7431dc2 fb96fbe change % change
bl602 lighting-app bl602 (read/write) 1355006 1355006 0 0.0
.bss 87057 87057 0 0.0
.data 9984 9984 0 0.0
.text 1037754 1037754 0 0.0
bl602+rpc (read/write) 1400694 1400694 0 0.0
.bss 95105 95105 0 0.0
.data 10384 10384 0 0.0
.text 1069084 1069084 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195407 1195407 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1526825 1526825 0 0.0
.debug_aranges 132456 132456 0 0.0
.debug_frame 485952 485952 0 0.0
.debug_info 3914823 3914823 0 0.0
.debug_line 5139755 5139755 0 0.0
.debug_loc 3373933 3373933 0 0.0
.debug_ranges 363504 363504 0 0.0
.debug_str 3475226 3475226 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116320 116320 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568447 568447 0 0.0
.symtab 172000 172000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
955956 955956 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284027 1284027 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1674031 1674031 0 0.0
.debug_aranges 140592 140592 0 0.0
.debug_frame 513388 513388 0 0.0
.debug_info 43444896 43444896 0 0.0
.debug_line 5529924 5529924 0 0.0
.debug_loc 3569270 3569270 0 0.0
.debug_ranges 387008 387008 0 0.0
.debug_str 3874831 3874831 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130032 130032 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 628601 628601 0 0.0
.symtab 190144 190144 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030060 1030060 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679467 679467 0 0.0
(read/write) 172068 172068 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89963 89963 0 0.0
.text 589192 589192 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643731 643731 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 79099 79099 0 0.0
.text 564312 564312 0 0.0
lock-ftd LP_CC2652R7 (read only) 677007 677007 0 0.0
(read/write) 172096 172096 0 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77391 77391 0 0.0
.text 599136 599136 0 0.0
lock-mtd LP_CC2652R7 (read only) 661803 661803 0 0.0
(read/write) 182556 182556 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103475 103475 0 0.0
.text 557848 557848 0 0.0
pump-app LP_CC2652R7 (read only) 689943 689943 0 0.0
(read/write) 159896 159896 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90911 90911 0 0.0
.text 598548 598548 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673851 673851 0 0.0
(read/write) 176084 176084 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86459 86459 0 0.0
.text 586912 586912 0 0.0
shell LP_CC2652R7 (read only) 670678 670678 0 0.0
(read/write) 183176 183176 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86710 86710 0 0.0
.text 583652 583652 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588342 588342 0 0.0
.app_xip_area 464592 464592 0 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592042 592042 0 0.0
.app_xip_area 462996 462996 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551522 551522 0 0.0
.app_xip_area 433284 433284 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976108 976108 0 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 821660 821660 0 0.0
BRD4161A+rs911x (read/write) 1037624 1037624 0 0.0
.bss 186736 186736 0 0.0
.data 2012 2012 0 0.0
.text 848856 848856 0 0.0
BRD4187C (read/write) 1149204 1149204 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 983436 983436 0 0.0
lock-app BRD4161A+wf200 (read/write) 1163312 1163312 0 0.0
.bss 158304 158304 0 0.0
.data 2020 2020 0 0.0
.text 1002968 1002968 0 0.0
window-app BRD4187C (read/write) 1141736 1141736 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 974528 974528 0 0.0
esp32 all-clusters-app c3devkit (read only) 1214706 1214706 0 0.0
(read/write) 1786710 1786710 0 0.0
.dram0.bss 76688 76688 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 256536 256536 0 0.0
.flash.text 1214706 1214706 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1225439 1225439 0 0.0
(read/write) 562668 562676 8 0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 313640 313648 8 0.0
.flash.text 1220055 1220055 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662516 662516 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564188 564188 0 0.0
light k32w0+release (read/write) 673104 673104 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 593404 593404 0 0.0
lock k32w0+release (read/write) 634060 634060 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 553580 553580 0 0.0
linux all-clusters-app debug (read only) 3111273 3111273 0 0.0
(read/write) 158504 158504 0 0.0
.bss 62464 62464 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87144 87144 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281227 281227 0 0.0
.text 2645554 2645554 0 0.0
all-clusters-minimal-app debug (read only) 2934953 2934953 0 0.0
(read/write) 149904 149904 0 0.0
.bss 61664 61664 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280683 280683 0 0.0
.text 2472818 2472818 0 0.0
bridge-app debug+rpc (read only) 2427633 2427633 0 0.0
(read/write) 129608 129608 0 0.0
.bss 51008 51008 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68776 68776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 210848 210848 0 0.0
.text 2049426 2049426 0 0.0
chip-tool debug (read only) 11141281 11141281 0 0.0
(read/write) 659616 659616 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 624352 624352 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 592997 592997 0 0.0
.text 9021844 9021844 0 0.0
chip-tool-ipv6only arm64 (read only) 10528956 10528956 0 0.0
(read/write) 707697 707697 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 652008 652008 0 0.0
.dynamic 560 560 0 0.0
.got 13944 13944 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 519500 519500 0 0.0
.text 8350996 8350996 0 0.0
lighting-app debug+rpc (read only) 2660849 2660849 0 0.0
(read/write) 132360 132360 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73896 73896 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227840 227840 0 0.0
.text 2256450 2256450 0 0.0
lock-app debug (read only) 2620137 2620137 0 0.0
(read/write) 127376 127376 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70840 70840 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244104 244104 0 0.0
.text 2204322 2204322 0 0.0
ota-provider-app debug (read only) 2412433 2412433 0 0.0
(read/write) 120904 120904 0 0.0
.bss 47936 47936 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64760 64760 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 216552 216552 0 0.0
.text 2027330 2027330 0 0.0
ota-requestor-app debug (read only) 2581025 2581025 0 0.0
(read/write) 129248 129248 0 0.0
.bss 50464 50464 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 70120 70120 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 223600 223600 0 0.0
.text 2179778 2179778 0 0.0
shell debug (read only) 2643713 2643713 0 0.0
(read/write) 142968 142968 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78040 78040 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239474 239474 0 0.0
.text 2244722 2244722 0 0.0
thermostat-no-ble arm64 (read only) 2422044 2422044 0 0.0
(read/write) 143649 143649 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 145092 145092 0 0.0
.text 2033200 2033200 0 0.0
tv-app debug (read only) 3283153 3283153 0 0.0
(read/write) 262152 262152 0 0.0
.bss 170808 170808 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80384 80384 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268376 268376 0 0.0
.text 2820786 2820786 0 0.0
tv-casting-app debug (read only) 5623369 5623369 0 0.0
(read/write) 162080 162080 0 0.0
.bss 52120 52120 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101408 101408 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 355833 355833 0 0.0
.text 4991410 4991410 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463264 2463264 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1425908 1425908 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190763 1190763 0 0.0
bss 145289 145289 0 0.0
rodata 144448 144448 0 0.0
text 819864 819864 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1360890 1360890 0 0.0
bss 105228 105228 0 0.0
rodata 211552 211552 0 0.0
text 759622 759622 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136407 1136407 0 0.0
bss 144524 144524 0 0.0
rodata 120764 120764 0 0.0
text 790028 790032 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1748436 1748436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238402 1238402 0 0.0
.debug_aranges 110752 110752 0 0.0
.debug_frame 371636 371636 0 0.0
.debug_info 27023254 27023254 0 0.0
.debug_line 3704465 3704465 0 0.0
.debug_loc 3616350 3616350 0 0.0
.debug_ranges 345544 345544 0 0.0
.debug_str 3444768 3444768 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571573 571573 0 0.0
.symtab 421984 421984 0 0.0
.text 0 0 0 0.0
1548672 1548672 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1690956 1690956 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1230293 1230293 0 0.0
.debug_aranges 110224 110224 0 0.0
.debug_frame 374692 374692 0 0.0
.debug_info 26760899 26760898 -1 -0.0
.debug_line 3723402 3723402 0 0.0
.debug_loc 3603956 3603956 0 0.0
.debug_ranges 344160 344160 0 0.0
.debug_str 3433780 3433780 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535662 535662 0 0.0
.symtab 408416 408416 0 0.0
.text 1491928 1491928 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1609156 1609156 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064892 1064892 0 0.0
.debug_aranges 102424 102424 0 0.0
.debug_frame 345028 345028 0 0.0
.debug_info 22227861 22227861 0 0.0
.debug_line 3290607 3290607 0 0.0
.debug_loc 3301880 3301880 0 0.0
.debug_ranges 308296 308296 0 0.0
.debug_str 3239366 3239366 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 471987 471987 0 0.0
.symtab 376784 376784 0 0.0
.text 1418312 1418312 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1642596 1642596 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066808 1066808 0 0.0
.debug_aranges 102808 102808 0 0.0
.debug_frame 346824 346824 0 0.0
.debug_info 22447317 22447316 -1 -0.0
.debug_line 3290372 3290372 0 0.0
.debug_loc 3323212 3323212 0 0.0
.debug_ranges 310152 310152 0 0.0
.debug_str 3255198 3255198 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473649 473649 0 0.0
.symtab 378384 378384 0 0.0
.text 1446760 1446760 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150884 1150884 0 0.0
.bss 97628 97628 0 0.0
.data 840 840 0 0.0
.text 597984 597984 0 0.0
lock-app qpg6105+debug (read/write) 1116756 1116756 0 0.0
.bss 93100 93100 0 0.0
.data 836 836 0 0.0
.text 563852 563852 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 939008 939008 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 650232 650232 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 876968 876968 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 614186 614186 0 0.0
light-switch-app tlsr9518adk80d (read/write) 792188 792188 0 0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 555330 555328 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 876516 876508 -8 -0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 625574 625572 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 806556 806556 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 566670 566668 -2 -0.0
thermostat tlsr9518adk80d (read/write) 793360 793360 0 0.0
bss 73852 73852 0 0.0
noinit 43480 43480 0 0.0
text 554306 554306 0 0.0

@andy31415 andy31415 merged commit fad4f23 into project-chip:master Dec 1, 2022
@bzbarsky-apple bzbarsky-apple deleted the nonnull-callback-bridge branch December 1, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksperling-apple ksperling-apple ksperling-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @andy31415 @msandstedt @ksperling-apple