-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsontlv] Add a prefix for octet strings encoded as base64 #23889
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:TlvToJson_Base64Prefix
Dec 7, 2022
Merged
[jsontlv] Add a prefix for octet strings encoded as base64 #23889
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:TlvToJson_Base64Prefix
Dec 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
December 2, 2022 21:38
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
December 2, 2022 21:38
PR #23889: Size comparison from 013514b to 5d0d691 Increases (12 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, esp32, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
TlvToJson_Base64Prefix
branch
from
December 5, 2022 10:16
5d0d691
to
955df5f
Compare
PR #23889: Size comparison from 9c0ca13 to 955df5f Increases (8 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TlvToJson
silently converts octet string to base64, this is OK as one may infer the type from the data model, but it not obvious at first sight and makes it hard to differentiate from regular strings, for examplelowUPPER
is a string but also a valid base64 octet string.It would be nice for users to tell them that the string is encoded, and what is the format, without having them to look at the implementation. This PR just adds a
base64:
prefix for those strings.