-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin: Expose MTRBaseDevice.sessionTransportType #24065
Merged
ksperling-apple
merged 1 commit into
project-chip:master
from
ksperling-apple:transport-type
Dec 14, 2022
Merged
Darwin: Expose MTRBaseDevice.sessionTransportType #24065
ksperling-apple
merged 1 commit into
project-chip:master
from
ksperling-apple:transport-type
Dec 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24065: Size comparison from 12b1744 to acd88aa Increases (1 build for telink)
Decreases (8 builds for k32w, nrfconnect, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24065: Size comparison from 12b1744 to c24115c Increases above 0.2%:
Increases (7 builds for bl702, cyw30739, linux, psoc6)
Decreases (6 builds for bl702, k32w, linux, psoc6)
Full report (29 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
ksperling-apple
force-pushed
the
transport-type
branch
from
December 14, 2022 00:52
c24115c
to
f002dec
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
December 14, 2022 00:52
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
December 14, 2022 00:52
PR #24065: Size comparison from 10cccdc to f002dec Increases (8 builds for bl702, psoc6, telink)
Decreases (7 builds for bl602, cyw30739, esp32, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 14, 2022
tcarmelveilleux
approved these changes
Dec 14, 2022
ksperling-apple
force-pushed
the
transport-type
branch
from
December 14, 2022 18:25
f002dec
to
75dd2da
Compare
PR #24065: Size comparison from 8774251 to 75dd2da Increases (3 builds for bl702, cc13x2_26x2, nrfconnect)
Decreases (7 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6)
Full report (29 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
- Use it in iOS CHIPTool - Remove _deviceBeingCommissionedOverBLE
ksperling-apple
force-pushed
the
transport-type
branch
from
December 14, 2022 20:27
75dd2da
to
040ebb4
Compare
PR #24065: Size comparison from 127deca to 040ebb4 Increases (7 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, telink)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, cyw30739, nrfconnect, psoc6)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose MTRBaseDevice.sessionTransportType