-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement unpairDevice API in android and chip-tool #24127
Implement unpairDevice API in android and chip-tool #24127
Conversation
PR #24127: Size comparison from 74296b8 to 8435a6e Increases above 0.2%:
Increases (6 builds for cc13x2_26x2, linux, nrfconnect, psoc6)
Decreases (8 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking much better!
…ectedhomeip into implement_unpairdevice
PR #24127: Size comparison from 19c8ea4 to f313f2f Increases above 0.2%:
Increases (11 builds for bl702, esp32, linux, nrfconnect, psoc6, telink)
Decreases (3 builds for bl602, esp32)
Full report (46 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24127: Size comparison from 19c8ea4 to 322f677 Increases above 0.2%:
Increases (16 builds for bl602, bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Decreases (2 builds for esp32, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24127: Size comparison from 7195bd8 to a682442 Increases above 0.2%:
Increases (5 builds for bl702, cc13x2_26x2, esp32, linux, psoc6)
Decreases (8 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* Implement unpairDevice * Check restyle * Delete unused file * Add default value * Update from review * Modify from reviewer comments * Modify from comment * Fix clang-tidy validation * Change check state
* Implement unpairDevice * Check restyle * Delete unused file * Add default value * Update from review * Modify from reviewer comments * Modify from comment * Fix clang-tidy validation * Change check state
Fixes #23523
Chip-tool and Android platform did not implement the unpairDevice, so I implemented it.
Check operation:
chip-tool : ./chip-tool pairing unpair [deviceId]
android : deviceController.unpairDevice(long deviceId)