-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in On/Off cluster XML with the spec. #24237
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-onoff-bits
Jan 3, 2023
Merged
Align naming in On/Off cluster XML with the spec. #24237
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-onoff-bits
Jan 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
January 3, 2023 14:30
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 3, 2023 14:30
tehampson
approved these changes
Jan 3, 2023
msandstedt
approved these changes
Jan 3, 2023
PR #24237: Size comparison from 8f9207d to 539c9d9 Increases (5 builds for bl602, psoc6, telink)
Decreases (13 builds for bl702, esp32, linux, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-onoff-bits
branch
from
January 3, 2023 16:40
539c9d9
to
6fb124b
Compare
yufengwangca
approved these changes
Jan 3, 2023
PR #24237: Size comparison from a83ce32 to 6fb124b Increases (9 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (12 builds for bl602, bl702, linux, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-onoff-bits
branch
from
January 3, 2023 18:19
6fb124b
to
58bfa39
Compare
PR #24237: Size comparison from 458bbbf to 58bfa39 Increases (9 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, telink)
Decreases (11 builds for bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Full report (39 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first commit contains manual changes.