-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in Access Control cluster with the spec. #24239
Merged
Damian-Nordic
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-access-control
Jan 4, 2023
Merged
Align naming in Access Control cluster with the spec. #24239
Damian-Nordic
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-access-control
Jan 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
mspang,
robszewczyk and
saurabhst
January 3, 2023 14:36
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 3, 2023 14:36
tehampson
approved these changes
Jan 3, 2023
PR #24239: Size comparison from 8f9207d to 8f73007 Increases (4 builds for bl702, linux, telink)
Decreases (8 builds for bl602, bl702, nrfconnect, telink)
Full report (28 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-access-control
branch
from
January 3, 2023 15:37
8f73007
to
cb230db
Compare
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Jan 3, 2023
bzbarsky-apple
force-pushed
the
rename-access-control
branch
2 times, most recently
from
January 3, 2023 16:51
bb876e6
to
961d9f9
Compare
PR #24239: Size comparison from a83ce32 to 961d9f9 Increases (15 builds for bl702, esp32, linux, nrfconnect, psoc6, telink)
Decreases (4 builds for bl602, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Except for Target, because TargetStruct is used in the Bindings cluster already.
bzbarsky-apple
force-pushed
the
rename-access-control
branch
from
January 4, 2023 02:08
961d9f9
to
5e3a8af
Compare
PR #24239: Size comparison from 23e5fb2 to 5e3a8af Increases (13 builds for bl702, esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for telink)
Full report (35 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
documentation
Improvements or additions to documentation
examples
review - approved
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except for Target, because TargetStruct is used in the Bindings cluster already.
REVIEW NOTE: Only the first commit contains manual changes.