-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Removed types from Kconfig overrides #24250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types should not be used in case of overriding existing kconfig definitions to make sure that compilation will fail due to creating a config without a type in case of name change in the origin kconfig option.
PR #24250: Size comparison from ac82038 to 919bcdb Increases (7 builds for bl702, esp32, nrfconnect, psoc6, telink)
Decreases (7 builds for bl702, esp32, nrfconnect, telink)
Full report (62 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Jan 4, 2023
andy31415
approved these changes
Jan 4, 2023
Damian-Nordic
pushed a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Jun 1, 2023
…ject-chip#24250) Types should not be used in case of overriding existing kconfig definitions to make sure that compilation will fail due to creating a config without a type in case of name change in the origin kconfig option. (cherry picked from commit 34f9130)
Damian-Nordic
pushed a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Jun 1, 2023
…des (project-chip#24250)" This reverts commit f229a83.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types should not be used in case of overriding existing kconfig definitions. It is to make sure that compilation will fail due to creating a config without a type in case of name change in the origin kconfig option.