-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in Ethernet Network Diagnostics cluster XML with the spec. #24296
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-ethernet-diagnostics
Jan 6, 2023
Merged
Align naming in Ethernet Network Diagnostics cluster XML with the spec. #24296
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-ethernet-diagnostics
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
January 6, 2023 00:06
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 6, 2023 00:06
PR #24296: Size comparison from 7f668cd to 449b1d1 Increases (1 build for bl702)
Decreases (6 builds for bl602, bl702, telink)
Full report (26 builds for bl602, bl702, cc13x2_26x2, k32w, mbed, nrfconnect, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-ethernet-diagnostics
branch
from
January 6, 2023 01:04
449b1d1
to
e0b8ea7
Compare
PR #24296: Size comparison from 7f668cd to e0b8ea7 Increases (4 builds for bl702, cyw30739, esp32, telink)
Decreases (9 builds for bl702, efr32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jan 6, 2023
ReneJosefsen
approved these changes
Jan 6, 2023
jtung-apple
approved these changes
Jan 6, 2023
bzbarsky-apple
force-pushed
the
rename-ethernet-diagnostics
branch
from
January 6, 2023 17:29
e0b8ea7
to
4808476
Compare
PR #24296: Size comparison from 9d5d9a5 to 4808476 Increases (7 builds for bl702, cc13x2_26x2, efr32, esp32, psoc6, telink)
Decreases (14 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-ethernet-diagnostics
branch
from
January 6, 2023 19:27
4808476
to
4325098
Compare
PR #24296: Size comparison from 0f76327 to 4325098 Increases (7 builds for bl702, cc13x2_26x2, psoc6, qpg)
Decreases (12 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cletnick
pushed a commit
to cletnick/connectedhomeip
that referenced
this pull request
Jan 10, 2023
…c. (project-chip#24296) * Align naming in Ethernet Network Diagnostics cluster XML with the spec. * Auto-update ZAP files with new attribute type. * Regenerate generated files.
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…c. (project-chip#24296) * Align naming in Ethernet Network Diagnostics cluster XML with the spec. * Auto-update ZAP files with new attribute type. * Regenerate generated files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first commit contains manual changes. The rest is code-generated.