-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in Door Lock cluster XML with the spec. #24358
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-door-lock
Jan 19, 2023
Merged
Align naming in Door Lock cluster XML with the spec. #24358
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-door-lock
Jan 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
January 11, 2023 00:19
bzbarsky-apple
force-pushed
the
rename-door-lock
branch
from
January 11, 2023 16:42
f007358
to
165bba6
Compare
PR #24358: Size comparison from 1dce789 to 165bba6 Increases (16 builds for bl702, cc13x2_26x2, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (13 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (65 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Jan 13, 2023
jmeg-sfy
reviewed
Jan 13, 2023
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Outdated
Show resolved
Hide resolved
jmeg-sfy
reviewed
Jan 13, 2023
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Outdated
Show resolved
Hide resolved
jmeg-sfy
reviewed
Jan 13, 2023
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Outdated
Show resolved
Hide resolved
bzbarsky-apple
force-pushed
the
rename-door-lock
branch
from
January 13, 2023 20:13
165bba6
to
9cf6a8c
Compare
PR #24358: Size comparison from a25af90 to 9cf6a8c Increases (16 builds for bl602, bl702, cc13x2_26x2, linux, mbed, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, efr32, esp32, telink)
Full report (65 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
approved these changes
Jan 16, 2023
bzbarsky-apple
force-pushed
the
rename-door-lock
branch
from
January 18, 2023 04:08
9cf6a8c
to
47e1691
Compare
PR #24358: Size comparison from 89c6fb6 to 47e1691 Increases (17 builds for bl702, cc13x2_26x2, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (5 builds for bl602, bl702, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-door-lock
branch
from
January 18, 2023 12:01
47e1691
to
df561a7
Compare
PR #24358: Size comparison from c5cb0dd to df561a7 Increases (11 builds for bl702, cc13x2_26x2, linux, nrfconnect, psoc6)
Decreases (10 builds for bl702, cc13x2_26x2, k32w, nrfconnect, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jan 18, 2023
bzbarsky-apple
force-pushed
the
rename-door-lock
branch
from
January 18, 2023 16:38
1c0bd35
to
092e238
Compare
PR #24358: Size comparison from 79f5657 to 092e238 Increases (11 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (10 builds for bl602, cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
Full report (65 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This was referenced Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first commit contains manual changes. The rest is code-generated.