-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in Color Control cluster XML with the spec. #24388
Merged
bzbarsky-apple
merged 4 commits into
project-chip:master
from
bzbarsky-apple:rename-color-control
Jan 19, 2023
Merged
Align naming in Color Control cluster XML with the spec. #24388
bzbarsky-apple
merged 4 commits into
project-chip:master
from
bzbarsky-apple:rename-color-control
Jan 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f29886
to
7b1e15f
Compare
7b1e15f
to
50e66d8
Compare
PR #24388: Size comparison from b36439e to 50e66d8 Increases (16 builds for bl702, cc13x2_26x2, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl602, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
reviewed
Jan 13, 2023
jmeg-sfy
approved these changes
Jan 13, 2023
50e66d8
to
76fc68b
Compare
PR #24388: Size comparison from a25af90 to 76fc68b Increases (10 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, cyw30739, esp32, linux, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24388: Size comparison from e1cb26c to 8e71a68 Increases (12 builds for bl702, cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Decreases (12 builds for bl702, cc13x2_26x2, linux, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…es in names. Instead this should be fixed on the spec side, which is tracked in CHIP-Specifications/connectedhomeip-spec#6174
8e71a68
to
24d2e78
Compare
PR #24388: Size comparison from 57de760 to 24d2e78 Increases (8 builds for bl702, psoc6, qpg, telink)
Decreases (5 builds for esp32, linux, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jan 19, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ip#24388) * Align naming in Color Control cluster XML with the spec. * Regenerate generated code. * Address review comment: undo changes that introduced spaces and slashes in names. Instead this should be fixed on the spec side, which is tracked in CHIP-Specifications/connectedhomeip-spec#6174 * Regenerate generated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first commit contains manual changes. The rest is code-generated.