-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in Content Launcher cluster XML with the spec. #24507
Merged
yufengwangca
merged 6 commits into
project-chip:master
from
bzbarsky-apple:rename-content-launcher
Jan 23, 2023
Merged
Align naming in Content Launcher cluster XML with the spec. #24507
yufengwangca
merged 6 commits into
project-chip:master
from
bzbarsky-apple:rename-content-launcher
Jan 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
force-pushed
the
rename-content-launcher
branch
from
January 18, 2023 23:54
29866bd
to
b478907
Compare
bzbarsky-apple
force-pushed
the
rename-content-launcher
branch
from
January 19, 2023 00:48
b478907
to
3b7f674
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple and
ksperling-apple
January 19, 2023 00:49
bzbarsky-apple
force-pushed
the
rename-content-launcher
branch
from
January 20, 2023 20:54
e290858
to
6c7d8ba
Compare
jtung-apple
approved these changes
Jan 20, 2023
PR #24507: Size comparison from 63ee965 to 6c7d8ba Increases (16 builds for bl702, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (7 builds for bl602, bl702, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-content-launcher
branch
from
January 21, 2023 00:15
6c7d8ba
to
cc974e3
Compare
PR #24507: Size comparison from 7f54fb6 to cc974e3 Increases (12 builds for bl702, linux, nrfconnect, psoc6, telink)
Decreases (10 builds for bl702, cyw30739, efr32, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…s with the same name.
bzbarsky-apple
force-pushed
the
rename-content-launcher
branch
from
January 21, 2023 04:49
cc974e3
to
9a229bf
Compare
PR #24507: Size comparison from 7b99e63 to 9a229bf Increases (15 builds for bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Jan 23, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jan 23, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jan 23, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jan 23, 2023
andy31415
pushed a commit
that referenced
this pull request
Jan 23, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…chip#24507) * Align naming in Content Launcher cluster XML with the spec. * Fix naming of LauncherResponse * Update ZAP to fix bug with same-named response commands. * Auto-update ZAP files. * Regenerate generated files. * Fix java codegen assuming two clusters will not have response commands with the same name.
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first commit contains manual changes. The rest is code-generated.