-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Add supports for OTA_SuccessfulTransfer specific S… #24659
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_OTASuccessfulCommands
Feb 1, 2023
Merged
[matter_yamltests] Add supports for OTA_SuccessfulTransfer specific S… #24659
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_OTASuccessfulCommands
Feb 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c810eae
to
55fef68
Compare
jtung-apple
approved these changes
Jan 26, 2023
tehampson
reviewed
Jan 26, 2023
scripts/py_matter_yamltests/matter_yamltests/pseudo_clusters/clusters/system_commands.py
Outdated
Show resolved
Hide resolved
PR #24659: Size comparison from dfa7c9d to 55fef68 Increases (7 builds for bl602, bl702, nrfconnect, psoc6, telink)
Decreases (4 builds for esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…ystemCommands and DelayCommands
55fef68
to
2c00a73
Compare
PR #24659: Size comparison from 25df49b to 2c00a73 Increases (5 builds for esp32, psoc6, telink)
Decreases (8 builds for bl602, bl702, k32w, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
reviewed
Feb 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, I just want to think about this just a little longer, but added one nit comment for the time being
tehampson
approved these changes
Feb 1, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ystemCommands and DelayCommands (project-chip#24659)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ystemCommands and DelayCommands
Problem
OTA_SuccessfulTransfer
has customSystemCommands/DelayCommands
it needs to runs the tests. This PR adds them and basically copy the content ofsrc/app/tests/suites/commands/*/scripts/[WaitForMessage|CompareFiles].py