[door-lock-cluster.xml] Remove some extra <access op=invoke role=admi… #24662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nister /> qualifications for responses.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
bzbarsky-apple
approved these changes
Jan 26, 2023
|
PR #24662: Size comparison from dfa7c9d to 82e0c8f Increases (7 builds for esp32, nrfconnect, telink)
Decreases (7 builds for bl602, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 26, 2023
LuDuda
pushed a commit
to LuDuda/connectedhomeip
that referenced
this pull request
Jan 29, 2023
…roject-chip#23664) * Switch zap workflows to use chip-build image * Remove zap third party submodule: we are using zap releases now * Switch "node zap-generate.js" with "zap-cli generate" * Undo openthread repo checkout * Remove reference to manufacturers.xml from zap repo * Remove references to third_party/zap * Add instructions to install zap from releases * Fix chip build version 09 is broken, need 10 after project-chip#24662 * Also add chip authors to manufacturers.xml copyright * update to image 0.6.11 so that we have npm in the image as well (should make javascript github actions work again) * Fix cmdargs arguments: run bootstrap not applicable anymore * Add safe.directory for git otherwise git operations fail. checkout_submodules used to do this, but without them we need a separate set * Provide options on how to execute zap using env variables * Update scripts to add back run_zaptool and zap_bootstrap.sh * Restyle and updated zaptool to be friendly with restyler * Update documentation to explain available environment variables * Restyle * Update docs/guides/BUILDING.md Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update docs/guides/BUILDING.md Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Add back run_bootstrap command line option * Restyle * Fix cmdline args * Fix typo * Make sure zap convert is also aware of environment variables * Update convert.py workind directory. tested with local zap * Add back run_bootstrap to regen_all and convert_all * Restyle * Spelling fix * Update run_zaptool to support install for mac * Update zap argument logic * Restyle Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…nister /> qualifications for responses. (project-chip#24662)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nister /> qualifications for responses.
Problem
The door lock cluster response have an access role that has been added. I just can't see it in the spec - it could be me looking wrongly though.