-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chip-repl tests: xml parsing to report location of where unrecognized handlers reside #24674
Merged
andy31415
merged 2 commits into
project-chip:master
from
andy31415:find_out_xml_error_locations
Jan 27, 2023
Merged
chip-repl tests: xml parsing to report location of where unrecognized handlers reside #24674
andy31415
merged 2 commits into
project-chip:master
from
andy31415:find_out_xml_error_locations
Jan 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
changed the title
Report location of where unrecognized handlers reside
chip-repl tests: xml parsing to report location of where unrecognized handlers reside
Jan 26, 2023
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
January 26, 2023 21:35
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 26, 2023 21:35
PR #24674: Size comparison from 86b064d to 59d4cba Increases (12 builds for bl602, bl702, cyw30739, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, esp32, k32w, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 27, 2023
shchen-Lab
added a commit
to bouffalolab/connectedhomeip-1
that referenced
this pull request
Feb 6, 2023
* tag 'TE_23_02/rc2': (374 commits) Fix placeholder app shutdown to actually do a clean stack shutdown. (project-chip#24714) [chip-repl tests] Update tests that can pass (project-chip#24708) [repl tests] Allow the ability to run all tests in the test suite (including manual) (project-chip#24707) Rename silabs/types.xml to silabs/types-silabs.xml to prevent it to be loaded before chip/chip-types.xml since zcl-loader-silabs.js::parseZclFiles reorder the files if it match types.xml (project-chip#24710) Replace more arm64 nodeps-clang variants with just nodeps as they are mutually exclusive (project-chip#24704) Fix cloudbuild targets: It is "all-clusters" and not "all-clusters-app" (project-chip#24703) [Telink] Improve the Identify Implementation & Update every image to 0.6.35 (project-chip#24690) Add ability to list all YAML tests and manually run them from the test runner (project-chip#24629) silabs_fix_lighting_app_lcd (project-chip#24661) TC-ACE-1.4 automation (project-chip#24157) Update TC_RR_1_1.py to match test spec changes. (project-chip#24664) [nrfconnect] Fixed window covering compilation failure (project-chip#24700) [Telink] Logs optimization (project-chip#24693) [tv-app + YAML tests] Update the yaml tests to use the correct formatting for the responses since CurrentChannel is a struct (project-chip#24696) [YAML tests] Add PICS code to Color Control WaitForDelay steps (project-chip#24699) chip-repl tests: xml parsing to report location of where unrecognized handlers reside (project-chip#24674) Remove Basic SWBuildId extension from zll.xml since there is no cluster with this code (0x0000) (project-chip#24689) [Thermostat Cluster] Move related bitmaps/enums from silabs/types.xml to chip/thermostat-cluster.xml (project-chip#24694) [darwin] Add [WiFi/Ethernet]NetworkDiagnosticsFeature bitmaps and their values to darwin availability register (project-chip#24692) Less XML parsing, resulting in less errors (project-chip#24667) ...
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
… handlers reside (project-chip#24674) * Report location of where unrecognized handlers reside * Restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of logs saying
WARNING:root:TAG configurator::global::command::description was not handled/recognized
when running repl tests.Unfortunately this is not clear as to where that is, so I made a change so now it will report
silabs/general.xml
in this case. This way we can review what handlers need to be checked or ignored.