Update Matter.framework API per API review decisions. #24680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix MTR_NEWLY_* to have the right versions in generated code.
This commit was generated by running the following commands:
git sed MTR_NEWLY_AVAILABLE 'API_AVAILABLE(ios(16.4), macos(13.3), watchos(9.4), tvos(16.4))' -- src/darwin/Framework/CHIP
git sed 'MTR_NEWLY_DEPRECATED("\([^"]*\)")' 'API_DEPRECATED("\1", ios(16.1, 16.4), macos(13.0, 13.3), watchos(9.1, 9.4), tvos(16.1, 16.4))' -- src/darwin/Framework/CHIP/
git restore src/darwin/Framework/CHIP/Matter.h
and then running restyle.
bzbarsky-apple
force-pushed
the
darwin-api-updates
branch
from
064dd6f to
bc96e93
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton and
jepenven-silabs
pullapprove
bot
requested review from
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pjzander-signify,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
|
PR #24680: Size comparison from 33ce048 to bc96e93 Increases (4 builds for bl702, cc13x2_26x2, nrfconnect, telink)
Decreases (8 builds for bl702, cc13x2_26x2, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ksperling-apple
approved these changes
Jan 27, 2023
examples/darwin-framework-tool/commands/provider/OTASoftwareUpdateInteractive.mm
Show resolved
Hide resolved
jtung-apple
reviewed
Jan 27, 2023
|
Fast-tracking platform-specific change with platform owner review. |
|
PR #24680: Size comparison from 33ce048 to a456c09 Increases above 0.2%:
Increases (52 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, linux, psoc6)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…4680) * Update Matter.framework API per API review decisions. * Regenerate generated files for API changes. * Update versioons in availability.yaml. This should fix MTR_NEWLY_* to have the right versions in generated code. * Regenerate generated code for version update. * Update MTR_NEWLY_* to have the right versions in non-generated code. This commit was generated by running the following commands: git sed MTR_NEWLY_AVAILABLE 'API_AVAILABLE(ios(16.4), macos(13.3), watchos(9.4), tvos(16.4))' -- src/darwin/Framework/CHIP git sed 'MTR_NEWLY_DEPRECATED("\([^"]*\)")' 'API_DEPRECATED("\1", ios(16.1, 16.4), macos(13.0, 13.3), watchos(9.1, 9.4), tvos(16.1, 16.4))' -- src/darwin/Framework/CHIP/ git restore src/darwin/Framework/CHIP/Matter.h and then running restyle. * Manually fix up MTR_NEWLY_DEPRECATED instances that the regexp missed. * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates the various availability annotations.
REVIEW NOTE: It might be easiest to review the changesets one at a time, since some of them are auto-generated, instead of reviewing the whole thing at once.