-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On kBindingsChangedViaCluster during UDC, pick target video player's nodeID from BindingTable #24706
Merged
chrisdecenzo
merged 3 commits into
project-chip:master
from
sharadb-amazon:recom-20230127
Feb 23, 2023
Merged
On kBindingsChangedViaCluster during UDC, pick target video player's nodeID from BindingTable #24706
chrisdecenzo
merged 3 commits into
project-chip:master
from
sharadb-amazon:recom-20230127
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
January 27, 2023 20:08
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 27, 2023 20:09
sharadb-amazon
force-pushed
the
recom-20230127
branch
from
January 27, 2023 20:14
a3dbb24
to
9edf55d
Compare
chrisdecenzo
approved these changes
Jan 27, 2023
sharadb-amazon
force-pushed
the
recom-20230127
branch
from
January 27, 2023 20:33
9edf55d
to
d39fa56
Compare
sharadb-amazon
changed the title
tv-casting-app: On kBindingsChangedViaCluster during UDC, pick target video player's nodeID from BindingTable
On kBindingsChangedViaCluster during UDC, pick target video player's nodeID from BindingTable
Jan 27, 2023
PR #24706: Size comparison from 42d0ac8 to a07ff5a Increases (26 builds for bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl702, cc13x2_26x2, k32w, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…deId of video player from BindingTable
sharadb-amazon
force-pushed
the
recom-20230127
branch
from
January 30, 2023 18:26
a07ff5a
to
448dce2
Compare
PR #24706: Size comparison from 35bd94d to 448dce2 Increases (26 builds for bl602, bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
… member of BindingTableAccess
hawk248
approved these changes
Feb 23, 2023
pullapprove
bot
requested review from
nivi-apple
and removed request for
ReneJosefsen
February 23, 2023 15:05
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…nodeID from BindingTable (project-chip#24706) * tv-casting-app: On kBindingsChangedViaCluster during UDC, pick out nodeId of video player from BindingTable * Avoiding passing a default accessing fabricIndex * Setting mAccessingFabricIndex used in NotifyBindingsChanged() as data member of BindingTableAccess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24267
Change summary
Testing
Tested with the Android tv-casting-app and the Linux tv-app as per the instructions in #24267