-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] ESP-IDF v5.0 support in few apps #24720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ac1ef4
to
e2c9679
Compare
PR #24720: Size comparison from 4f24db4 to e2c9679 Increases (16 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (3 builds for cc13x2_26x2, cyw30739, esp32)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24720: Size comparison from 4f24db4 to b1cba58 Increases (9 builds for bl602, esp32, psoc6, telink)
Decreases (4 builds for esp32, qpg, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jan 30, 2023
andy31415
approved these changes
Jan 30, 2023
bzbarsky-apple
approved these changes
Jan 30, 2023
- Fixed few format specifier - Using the older version of led_strip, v1.0.0-alpha, which is present in idf v4.4.3 to avoid putting in more ifdefs in the code.
- Fixed few format specifier - Using the older version of led_strip, v1.0.0-alpha, which is present in idf v4.4.3 to avoid putting in more ifdefs in the code.
- Fixed few format specifier
- Fixed few format specifiers
b1cba58
to
c5ac87e
Compare
PR #24720: Size comparison from 5a845c6 to c5ac87e Increases (13 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, cyw30739, esp32, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chshu
approved these changes
Feb 3, 2023
andy31415
approved these changes
Feb 3, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* [ESP32] all-clusters-app: changes to support idf v5.0 - Fixed few format specifier - Using the older version of led_strip, v1.0.0-alpha, which is present in idf v4.4.3 to avoid putting in more ifdefs in the code. * [ESP32] all-clusters-minimal-app: changes to support idf v5.0 - Fixed few format specifier - Using the older version of led_strip, v1.0.0-alpha, which is present in idf v4.4.3 to avoid putting in more ifdefs in the code. * Added esp idf component manager related files to .gitignore * [ESP32] bridge-app: changes to support idf v5.0 - Fixed few format specifier * [ESP32] light-switch-app: changes to support idf v5.0 - Fixed few format specifiers * restyle * remove ErrorStr.h from bridge app * added reason for adding files to .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change Overview
Added support for esp-idf v5.0 in following applications all-clusters-app, all-clusters-minimal-app, bridge-app, and light-switch-app
In a nutshell:
ErrorStr
toerr.Format()
Testing