-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Subscription Persistence and Resumption for ESP32 #24759
Merged
andy31415
merged 2 commits into
project-chip:master
from
jtung-apple:jtung/enable_subscription_resumption_espressif
Feb 1, 2023
Merged
Enable Subscription Persistence and Resumption for ESP32 #24759
andy31415
merged 2 commits into
project-chip:master
from
jtung-apple:jtung/enable_subscription_resumption_espressif
Feb 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
January 31, 2023 19:02
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
January 31, 2023 19:02
PR #24759: Size comparison from f951fa9 to 9017cc0 Increases above 0.2%:
Increases (8 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, qpg)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jan 31, 2023
@jtung-apple Thanks. Was this tested locally and works fine with ESP32? |
dhrishi
approved these changes
Feb 1, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…p#24759) * Enable Subscription Persistence and Resumption for ESP32 * restyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the 1.1 feature Subscription Persistence and Resumption for ESP32, so that we can get more CI and other testing by default, so we can find issues early and fix as needed.
@shubhamdp @dhrishi for attention.