-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java-matter-controller] Add pairing already-discovered command #24916
Merged
yufengwangca
merged 3 commits into
project-chip:master
from
yufengwangca:pr/java/ipaddress
Feb 9, 2023
Merged
[java-matter-controller] Add pairing already-discovered command #24916
yufengwangca
merged 3 commits into
project-chip:master
from
yufengwangca:pr/java/ipaddress
Feb 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple and
ksperling-apple
February 8, 2023 08:35
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
February 8, 2023 08:35
PR #24916: Size comparison from e32359f to fb6c40b Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
requested changes
Feb 8, 2023
...controller/java/src/com/matter/controller/commands/pairing/PairAlreadyDiscoveredCommand.java
Show resolved
Hide resolved
bzbarsky-apple
approved these changes
Feb 9, 2023
yunhanw-google
approved these changes
Feb 9, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ect-chip#24916) * [java-matter-controller] Add pairing already-discovered command * Address review comments * Update helper text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we need to keep the pair by ip address API in SDK to support Java JNI implementation and already shipped Darwin software, we should have some way to exercise this API.