-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TestMultiAdmin to run on chip-repl based yamltest #24919
Merged
andy31415
merged 7 commits into
project-chip:master
from
tehampson:fix-TestMultiAdmin-0206
Feb 9, 2023
Merged
Fix TestMultiAdmin to run on chip-repl based yamltest #24919
andy31415
merged 7 commits into
project-chip:master
from
tehampson:fix-TestMultiAdmin-0206
Feb 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehampson
force-pushed
the
fix-TestMultiAdmin-0206
branch
from
February 8, 2023 15:09
0a175db
to
c5f63f9
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
jtung-apple
February 8, 2023 15:14
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 8, 2023 15:14
PR #24919: Size comparison from c7b1748 to 252f0e8 Full report (2 builds for cc32xx, mbed)
|
src/controller/python/ChipDeviceController-ScriptDevicePairingDelegate.cpp
Show resolved
Hide resolved
21 tasks
PR #24919: Size comparison from c7b1748 to 10f0371 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Feb 8, 2023
PR #24919: Size comparison from a55b245 to 3da8a12 Full report (1 build for cc32xx)
|
andy31415
approved these changes
Feb 9, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…4919) * Fix TestMultiAdmin to run on chip-repl based yamltest * Restyle * Address PR comment * Restyle * Restyle * Fix CI test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When chip-repl calls
CommissionWithCode
it hangs failing to get a callback about an error on pairing failure after the timeout caused byOnDeviceDiscoveredTimeoutCallback
. This hang was likely introduced in #16224. After that PR landed whenDeviceCommissioner::PairDevice
is called and usesSetUpCodePairer
to help discover and establish a PASE session, if no connection is ever discovered the original caller is no longer notified of the timeout error via OnPairingComplete callback. The decision in that PR to no longer callOnPairingComplete
in this circumstance was because callingOnPairingComplete
should only occur when there is a PASE establishment ongoing. For that reason we need to rely onOnStatusUpdate
withSecurePairingFailed
to indicate that there was an issue failing an call the required callback expected by chip-repl