Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestMultiAdmin to run on chip-repl based yamltest #24919

Merged
merged 7 commits into from
Feb 9, 2023

Conversation

tehampson
Copy link
Contributor

Problem: When chip-repl calls CommissionWithCode it hangs failing to get a callback about an error on pairing failure after the timeout caused by OnDeviceDiscoveredTimeoutCallback. This hang was likely introduced in #16224. After that PR landed when DeviceCommissioner::PairDevice is called and uses SetUpCodePairer to help discover and establish a PASE session, if no connection is ever discovered the original caller is no longer notified of the timeout error via OnPairingComplete callback. The decision in that PR to no longer call OnPairingComplete in this circumstance was because calling OnPairingComplete should only occur when there is a PASE establishment ongoing. For that reason we need to rely on OnStatusUpdate with SecurePairingFailed to indicate that there was an issue failing an call the required callback expected by chip-repl

@tehampson tehampson force-pushed the fix-TestMultiAdmin-0206 branch from 0a175db to c5f63f9 Compare February 8, 2023 15:09
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24919: Size comparison from c7b1748 to 252f0e8

Full report (2 builds for cc32xx, mbed)
platform target config section c7b1748 252f0e8 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640113 640113 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928401 928401 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 299792 299792 0 0.0
.debug_info 20130724 20130724 0 0.0
.debug_line 2649331 2649331 0 0.0
.debug_loc 2785586 2785586 0 0.0
.debug_ranges 280656 280656 0 0.0
.debug_str 2978943 2978943 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105593 105593 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375660 375660 0 0.0
.symtab 255728 255728 0 0.0
.text 532396 532396 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464392 2464392 0 0.0
.bss 215892 215892 0 0.0
.data 5880 5880 0 0.0
.text 1427036 1427036 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24919: Size comparison from c7b1748 to 10f0371

Increases above 0.2%:

platform target config section c7b1748 10f0371 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20130724 20194647 63923 0.3
.debug_str 2978943 3001804 22861 0.8
Increases (1 build for cc32xx)
platform target config section c7b1748 10f0371 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 640113 640233 120 0.0
.debug_abbrev 928401 928439 38 0.0
.debug_aranges 87336 87352 16 0.0
.debug_frame 299792 299840 48 0.0
.debug_info 20130724 20194647 63923 0.3
.debug_line 2649331 2649781 450 0.0
.debug_loc 2785586 2785870 284 0.0
.debug_ranges 280656 280720 64 0.0
.debug_str 2978943 3001804 22861 0.8
.strtab 375660 375840 180 0.0
.symtab 255728 255856 128 0.1
.text 532396 532524 128 0.0
Decreases (1 build for cc32xx)
platform target config section c7b1748 10f0371 change % change
cc32xx lock CC3235SF_LAUNCHXL .rodata 105593 105585 -8 -0.0
Full report (1 build for cc32xx)
platform target config section c7b1748 10f0371 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640113 640233 120 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928401 928439 38 0.0
.debug_aranges 87336 87352 16 0.0
.debug_frame 299792 299840 48 0.0
.debug_info 20130724 20194647 63923 0.3
.debug_line 2649331 2649781 450 0.0
.debug_loc 2785586 2785870 284 0.0
.debug_ranges 280656 280720 64 0.0
.debug_str 2978943 3001804 22861 0.8
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105593 105585 -8 -0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375660 375840 180 0.0
.symtab 255728 255856 128 0.1
.text 532396 532524 128 0.0

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

PR #24919: Size comparison from a55b245 to 3da8a12

Full report (1 build for cc32xx)
platform target config section a55b245 3da8a12 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194394 20194394 0 0.0
.debug_line 2649797 2649797 0 0.0
.debug_loc 2785922 2785922 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001474 3001474 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@andy31415 andy31415 merged commit 11c0cdf into project-chip:master Feb 9, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…4919)

* Fix TestMultiAdmin to run on chip-repl based yamltest

* Restyle

* Address PR comment

* Restyle

* Restyle

* Fix CI test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants