Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESP32] Fixed compilation with Bluedroid related errors for all-clusters-app. #25006

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

shripad621git
Copy link
Contributor

@shripad621git shripad621git commented Feb 13, 2023

This PR aims to fix the compilation errors in compilation of all-clusters-app with Bluedroid.
Problem:
The compilation of all-clusters-app was failing when compiled with Bluedroid as the option set in the menuconfig for Bluetooth host on ESP32 platform.

Change Overview:
Included the log library <esp_log.h> to fix the log related errors encountered in examples/all-clusters-app/esp32/main/DeviceCallbacks.cpp and examples/platform/esp32/lock/BoltLockManager.cpp.

Testing
Successfully compiled the all-clusters-app for esp32c3 with Bluedroid as the option set in the menuconfig for Bluetooth host.

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

PR #25006: Size comparison from bbfd5d6 to 55cc267

Full report (1 build for cc32xx)
platform target config section bbfd5d6 55cc267 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194444 20194444 0 0.0
.debug_line 2649825 2649825 0 0.0
.debug_loc 2785969 2785969 0 0.0
.debug_ranges 280696 280696 0 0.0
.debug_str 3001474 3001474 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@github-actions
Copy link

PR #25006: Size comparison from bbfd5d6 to 0636879

Decreases (1 build for cc32xx)
platform target config section bbfd5d6 0636879 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194444 20194443 -1 -0.0
Full report (1 build for cc32xx)
platform target config section bbfd5d6 0636879 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194444 20194443 -1 -0.0
.debug_line 2649825 2649825 0 0.0
.debug_loc 2785969 2785969 0 0.0
.debug_ranges 280696 280696 0 0.0
.debug_str 3001474 3001474 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@shripad621git shripad621git changed the title Fixed compilation with Bluedroid related errors for all-clusters-app. [ESP32] Fixed compilation with Bluedroid related errors for all-clusters-app. Feb 13, 2023
@andy31415 andy31415 merged commit b04c8ca into project-chip:master Feb 13, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants