Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align naming in Time Synchronization Cluster XML with the spec. #25037

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Align naming in Time Synchronization Cluster XML with the spec. #25037

merged 2 commits into from
Feb 14, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple force-pushed the rename-time-synchronization branch from dd2bfbb to 1614f4e Compare February 14, 2023 04:22
@github-actions
Copy link

PR #25037: Size comparison from 6ce0f90 to 1614f4e

Increases (1 build for cc32xx)
platform target config section 6ce0f90 1614f4e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20180781 20180782 1 0.0
.debug_str 3005287 3005325 38 0.0
Full report (1 build for cc32xx)
platform target config section 6ce0f90 1614f4e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640361 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20180781 20180782 1 0.0
.debug_line 2649926 2649926 0 0.0
.debug_loc 2786017 2786017 0 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3005287 3005325 38 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532604 0 0.0

@woody-apple woody-apple enabled auto-merge (squash) February 14, 2023 16:55
@woody-apple woody-apple merged commit 99be908 into project-chip:master Feb 14, 2023
@bzbarsky-apple bzbarsky-apple deleted the rename-time-synchronization branch February 14, 2023 17:04
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Align naming in Time Synchronization Cluster XML with the spec. (proj…
abc059f 
…ect-chip#25037)

* Align naming in Time Synchronization Cluster XML with the spec.

More spec changes happened in CHIP-Specifications/connectedhomeip-spec#6212

Fixes project-chip#25001

* Regenerate generated code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneJosefsen ReneJosefsen ReneJosefsen approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app controller darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[XML] Update Time Synchronization Cluster XML to match updated spec
4 participants
@bzbarsky-apple @andy31415 @woody-apple @ReneJosefsen