Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unused config options from config.h. #25164

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Remove some unused config options from config.h. #25164

merged 1 commit into from
Feb 20, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

No description provided.

@bzbarsky-apple bzbarsky-apple force-pushed the remove-unused-config-options branch from daad564 to 787eb58 Compare February 17, 2023 18:12
@bzbarsky-apple bzbarsky-apple force-pushed the remove-unused-config-options branch from 787eb58 to 1cfb204 Compare February 17, 2023 18:54
@github-actions
Copy link

PR #25164: Size comparison from d7b845a to 1cfb204

Increases (1 build for cc32xx)
platform target config section d7b845a 1cfb204 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 934242 934263 21 0.0
Decreases (1 build for cc32xx)
platform target config section d7b845a 1cfb204 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642209 642201 -8 -0.0
.debug_info 20361459 20361434 -25 -0.0
.debug_line 2661258 2661218 -40 -0.0
.debug_loc 2797585 2797537 -48 -0.0
.text 534384 534376 -8 -0.0
Full report (1 build for cc32xx)
platform target config section d7b845a 1cfb204 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642209 642201 -8 -0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934263 21 0.0
.debug_aranges 87472 87472 0 0.0
.debug_frame 300288 300288 0 0.0
.debug_info 20361459 20361434 -25 -0.0
.debug_line 2661258 2661218 -40 -0.0
.debug_loc 2797585 2797537 -48 -0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3020435 3020435 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534384 534376 -8 -0.0

@bzbarsky-apple bzbarsky-apple force-pushed the remove-unused-config-options branch from 1cfb204 to a4fe652 Compare February 17, 2023 21:36
@github-actions
Copy link

PR #25164: Size comparison from 01b88b4 to a4fe652

Increases (1 build for cc32xx)
platform target config section 01b88b4 a4fe652 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 934242 934263 21 0.0
Decreases (1 build for cc32xx)
platform target config section 01b88b4 a4fe652 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642217 642201 -16 -0.0
.debug_info 20360344 20360319 -25 -0.0
.debug_line 2661062 2661022 -40 -0.0
.debug_loc 2797107 2797059 -48 -0.0
.text 534392 534376 -16 -0.0
Full report (1 build for cc32xx)
platform target config section 01b88b4 a4fe652 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642217 642201 -16 -0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934263 21 0.0
.debug_aranges 87448 87448 0 0.0
.debug_frame 300212 300212 0 0.0
.debug_info 20360344 20360319 -25 -0.0
.debug_line 2661062 2661022 -40 -0.0
.debug_loc 2797107 2797059 -48 -0.0
.debug_ranges 281744 281744 0 0.0
.debug_str 3019502 3019502 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534392 534376 -16 -0.0

@bzbarsky-apple bzbarsky-apple force-pushed the remove-unused-config-options branch from a4fe652 to ff71007 Compare February 18, 2023 00:03
@github-actions
Copy link

PR #25164: Size comparison from 5b358b2 to ff71007

Increases (1 build for cc32xx)
platform target config section 5b358b2 ff71007 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 934242 934263 21 0.0
Decreases (1 build for cc32xx)
platform target config section 5b358b2 ff71007 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642217 642201 -16 -0.0
.debug_info 20360345 20360317 -28 -0.0
.debug_line 2661062 2661022 -40 -0.0
.debug_loc 2797107 2797059 -48 -0.0
.text 534392 534376 -16 -0.0
Full report (3 builds for cc32xx, qpg)
platform target config section 5b358b2 ff71007 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642217 642201 -16 -0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934263 21 0.0
.debug_aranges 87448 87448 0 0.0
.debug_frame 300212 300212 0 0.0
.debug_info 20360345 20360317 -28 -0.0
.debug_line 2661062 2661022 -40 -0.0
.debug_loc 2797107 2797059 -48 -0.0
.debug_ranges 281744 281744 0 0.0
.debug_str 3019502 3019502 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534392 534376 -16 -0.0
qpg lighting-app qpg6105+debug (read/write) 1150636 1150636 0 0.0
.bss 99820 99820 0 0.0
.data 852 852 0 0.0
.text 597732 597732 0 0.0
lock-app qpg6105+debug (read/write) 1118204 1118204 0 0.0
.bss 96316 96316 0 0.0
.data 864 864 0 0.0
.text 565304 565304 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit c11ee46 into project-chip:master Feb 20, 2023
@bzbarsky-apple bzbarsky-apple deleted the remove-unused-config-options branch February 20, 2023 14:32
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Remove some unused config options from config.h. (project-chip#25164)
4237c35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkq arkq arkq approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @arkq