Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't claim minimal mdns is initialized until it's advertising on some IPv6 interface. #25173

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Don't claim minimal mdns is initialized until it's advertising on some IPv6 interface. #25173

merged 1 commit into from
Feb 20, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

This fixes two things:

  1. We now don't consider advertising properly initialized until we are advertising on at least one ipv6 interface.

  2. Actually check which sorts of addresses interfaces have, instead of just assuming that all interfaces have both IPv4 and IPv6 addresses.

Fixes #25013

@bzbarsky-apple
Don't claim minimal mdns is initialized until it's advertising on som…
e2db3b7 
…e IPv6 interface.

This fixes two things:

1. We now don't consider advertising properly initialized until we are
   advertising on at least one ipv6 interface.

2. Actually check which sorts of addresses interfaces have, instead of
   just assuming that all interfaces have both IPv4 and IPv6 addresses.

Fixes project-chip#25013
@bzbarsky-apple bzbarsky-apple mentioned this pull request Feb 17, 2023
Closed
@github-actions github-actions bot added the lib label Feb 17, 2023
@github-actions
Copy link

github-actions bot commented Feb 17, 2023 •
edited
Loading

PR #25173: Size comparison from 01b88b4 to e2db3b7

Increases (9 builds for bl602, bl702, cc13x2_26x2, cc32xx, linux, mbed, qpg)
platform target config section 01b88b4 e2db3b7 change % change
bl602 lighting-app bl602 (read/write) 1348706 1348962 256 0.0
.text 1025084 1025344 260 0.0
bl602+rpc (read/write) 1394130 1394386 256 0.0
.text 1056020 1056278 258 0.0
bl702 lighting-app bl702 .debug_info 40701841 40701842 1 0.0
.text 954682 954684 2 0.0
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 159796 159804 8 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 642217 642449 232 0.0
.debug_abbrev 934242 934285 43 0.0
.debug_aranges 87448 87456 8 0.0
.debug_frame 300212 300240 28 0.0
.debug_info 20360344 20361466 1122 0.0
.debug_line 2661062 2661468 406 0.0
.debug_loc 2797107 2797738 631 0.0
.debug_ranges 281744 281760 16 0.0
.debug_str 3019502 3019558 56 0.0
.strtab 377379 377487 108 0.0
.symtab 256048 256096 48 0.0
.text 534392 534620 228 0.0
linux chip-tool-ipv6only arm64 (read only) 12060708 12060980 272 0.0
.text 9744372 9744644 272 0.0
thermostat-no-ble arm64 (read only) 2516220 2516508 288 0.0
.text 2102752 2103040 288 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2466544 2466672 128 0.0
.text 1429188 1429316 128 0.0
qpg lock-app qpg6105+debug (read/write) 1118196 1118204 8 0.0
.text 565296 565304 8 0.0
Decreases (5 builds for cc13x2_26x2, telink)
platform target config section 01b88b4 e2db3b7 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 643279 643271 -8 -0.0
.text 564728 564720 -8 -0.0
pump-app LP_CC2652R7 (read only) 689387 689379 -8 -0.0
.text 597976 597968 -8 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 871676 871668 -8 -0.0
text 592918 592914 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 949728 949720 -8 -0.0
text 658984 658980 -4 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 883068 883060 -8 -0.0
text 602722 602720 -2 -0.0
Full report (27 builds for bl602, bl702, cc13x2_26x2, cc32xx, k32w, linux, mbed, qpg, telink)
platform target config section 01b88b4 e2db3b7 change % change
bl602 lighting-app bl602 (read/write) 1348706 1348962 256 0.0
.bss 94690 94690 0 0.0
.data 9736 9736 0 0.0
.text 1025084 1025344 260 0.0
bl602+rpc (read/write) 1394130 1394386 256 0.0
.bss 102738 102738 0 0.0
.data 10128 10128 0 0.0
.text 1056020 1056278 258 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1187267 1187267 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69793 69793 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4064 4064 0 0.0
.debug_abbrev 1556113 1556113 0 0.0
.debug_aranges 134376 134376 0 0.0
.debug_frame 492532 492532 0 0.0
.debug_info 40701841 40701842 1 0.0
.debug_line 5284141 5284141 0 0.0
.debug_loc 3417622 3417622 0 0.0
.debug_ranges 372072 372072 0 0.0
.debug_str 3575802 3575802 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107568 107568 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 573412 573412 0 0.0
.symtab 173472 173472 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
954682 954684 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1280415 1280415 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77841 77841 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1704359 1704359 0 0.0
.debug_aranges 142616 142616 0 0.0
.debug_frame 520296 520296 0 0.0
.debug_info 45117268 45117268 0 0.0
.debug_line 5683184 5683184 0 0.0
.debug_loc 3614576 3614576 0 0.0
.debug_ranges 395848 395848 0 0.0
.debug_str 3979339 3979339 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122208 122208 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 634476 634476 0 0.0
.symtab 191936 191936 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1032092 1032092 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679935 679935 0 0.0
(read/write) 171160 171160 0 0.0
.bss 80788 80788 0 0.0
.data 3388 3388 0 0.0
.rodata 88319 88319 0 0.0
.text 591300 591300 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643279 643271 -8 -0.0
(read/write) 157500 157500 0 0.0
.bss 79996 79996 0 0.0
.data 3388 3388 0 0.0
.rodata 78231 78231 0 0.0
.text 564728 564720 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 676447 676447 0 0.0
(read/write) 172016 172016 0 0.0
.bss 78244 78244 0 0.0
.data 3316 3316 0 0.0
.rodata 76679 76679 0 0.0
.text 599288 599288 0 0.0
lock-mtd LP_CC2652R7 (read only) 662947 662947 0 0.0
(read/write) 180772 180772 0 0.0
.bss 73500 73500 0 0.0
.data 3316 3316 0 0.0
.rodata 103299 103299 0 0.0
.text 559168 559168 0 0.0
pump-app LP_CC2652R7 (read only) 689387 689379 -8 -0.0
(read/write) 159796 159804 8 0.0
.bss 78196 78196 0 0.0
.data 3280 3280 0 0.0
.rodata 90931 90931 0 0.0
.text 597976 597968 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 674571 674571 0 0.0
(read/write) 174740 174740 0 0.0
.bss 78324 78324 0 0.0
.data 3304 3304 0 0.0
.rodata 86931 86931 0 0.0
.text 587160 587160 0 0.0
shell LP_CC2652R7 (read only) 671198 671198 0 0.0
(read/write) 181968 181968 0 0.0
.bss 82860 82860 0 0.0
.data 3384 3384 0 0.0
.rodata 85070 85070 0 0.0
.text 585816 585816 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 642217 642449 232 0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934285 43 0.0
.debug_aranges 87448 87456 8 0.0
.debug_frame 300212 300240 28 0.0
.debug_info 20360344 20361466 1122 0.0
.debug_line 2661062 2661468 406 0.0
.debug_loc 2797107 2797738 631 0.0
.debug_ranges 281744 281760 16 0.0
.debug_str 3019502 3019558 56 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377487 108 0.0
.symtab 256048 256096 48 0.0
.text 0 0 0 0.0
534392 534620 228 0.0
k32w contact k32w0+release (read/write) 669864 669864 0 0.0
.bss 77548 77548 0 0.0
.data 2204 2204 0 0.0
.text 571000 571000 0 0.0
light k32w0+release (read/write) 668868 668868 0 0.0
.bss 77252 77252 0 0.0
.data 2192 2192 0 0.0
.text 570312 570312 0 0.0
lock k32w0+release (read/write) 625720 625720 0 0.0
.bss 75388 75388 0 0.0
.data 2136 2136 0 0.0
.text 545468 545468 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12060708 12060980 272 0.0
(read/write) 729224 729224 0 0.0
.bss 34136 34136 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 671552 671552 0 0.0
.dynamic 560 560 0 0.0
.got 15328 15328 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 585780 585780 0 0.0
.text 9744372 9744644 272 0.0
thermostat-no-ble arm64 (read only) 2516220 2516508 288 0.0
(read/write) 145096 145096 0 0.0
.bss 56312 56312 0 0.0
.data 1832 1832 0 0.0
.data.rel.ro 77568 77568 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151320 151320 0 0.0
.text 2102752 2103040 288 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466544 2466672 128 0.0
.bss 215812 215812 0 0.0
.data 5880 5880 0 0.0
.text 1429188 1429316 128 0.0
qpg lighting-app qpg6105+debug (read/write) 1150636 1150636 0 0.0
.bss 99820 99820 0 0.0
.data 852 852 0 0.0
.text 597732 597732 0 0.0
lock-app qpg6105+debug (read/write) 1118196 1118204 8 0.0
.bss 96316 96316 0 0.0
.data 864 864 0 0.0
.text 565296 565304 8 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015724 1015724 0 0.0
bss 97788 97788 0 0.0
text 686846 686846 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951424 951424 0 0.0
bss 96840 96840 0 0.0
text 648370 648370 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 855956 855956 0 0.0
bss 88968 88968 0 0.0
text 578910 578910 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 871676 871668 -8 -0.0
bss 89052 89052 0 0.0
text 592918 592914 -4 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 949728 949720 -8 -0.0
bss 97196 97196 0 0.0
text 658984 658980 -4 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883068 883060 -8 -0.0
bss 89996 89996 0 0.0
text 602722 602720 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875760 875760 0 0.0
bss 90444 90444 0 0.0
text 594326 594326 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 07b9bc7 into project-chip:master Feb 20, 2023
@bzbarsky-apple bzbarsky-apple deleted the minmdns-init-ipv6 branch February 20, 2023 14:33
@bzbarsky-apple bzbarsky-apple mentioned this pull request Mar 8, 2023
Closed
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Don't claim minimal mdns is initialized until it's advertising on som…
743576e 
…e IPv6 interface. (project-chip#25173)

This fixes two things:

1. We now don't consider advertising properly initialized until we are
   advertising on at least one ipv6 interface.

2. Actually check which sorts of addresses interfaces have, instead of
   just assuming that all interfaces have both IPv4 and IPv6 addresses.

Fixes project-chip#25013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkasperczyk-no kkasperczyk-no kkasperczyk-no approved these changes

@jtung-apple jtung-apple jtung-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@kcoppock kcoppock Awaiting requested review from kcoppock

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ESP32] Subscription Persistence and Resumption don't work on ESP32
3 participants
@bzbarsky-apple @kkasperczyk-no @jtung-apple