Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite discover-once to really stop right after the first PASE sessi… #25176

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Rewrite discover-once to really stop right after the first PASE sessi… #25176

merged 1 commit into from
Feb 21, 2023

Conversation

vivien-apple
Copy link
Contributor

…on failure

Problem

The discover-once argument for chip-tool is not really stopping the PASE establishment. This PR update the code such that it really only tries a single ip .

I suspect that is should fix the issues related to discover-once, notably:
#fix #24971
#fix #22547
#fix #22407

@vivien-apple vivien-apple self-assigned this Feb 17, 2023
@github-actions
Copy link

github-actions bot commented Feb 18, 2023 •
edited
Loading

PR #25176: Size comparison from 5b358b2 to e9cb74c

Increases (3 builds for bl602, bl702, linux)
platform target config section 5b358b2 e9cb74c change % change
bl602 lighting-app bl602+rpc .text 1056018 1056020 2 0.0
bl702 lighting-app bl702 .debug_info 40701841 40701842 1 0.0
.text 954682 954684 2 0.0
linux chip-tool-ipv6only arm64 .text 9744372 9744404 32 0.0
Decreases (2 builds for linux, qpg)
platform target config section 5b358b2 e9cb74c change % change
linux chip-tool-ipv6only arm64 .rodata 585780 585748 -32 -0.0
qpg lighting-app qpg6105+debug (read/write) 1150636 1150628 -8 -0.0
.text 597732 597724 -8 -0.0
Full report (16 builds for bl602, bl702, cc13x2_26x2, cc32xx, linux, qpg)
platform target config section 5b358b2 e9cb74c change % change
bl602 lighting-app bl602 (read/write) 1348706 1348706 0 0.0
.bss 94690 94690 0 0.0
.data 9736 9736 0 0.0
.text 1025084 1025084 0 0.0
bl602+rpc (read/write) 1394130 1394130 0 0.0
.bss 102738 102738 0 0.0
.data 10128 10128 0 0.0
.text 1056018 1056020 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1187267 1187267 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69793 69793 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4064 4064 0 0.0
.debug_abbrev 1556113 1556113 0 0.0
.debug_aranges 134376 134376 0 0.0
.debug_frame 492532 492532 0 0.0
.debug_info 40701841 40701842 1 0.0
.debug_line 5284141 5284141 0 0.0
.debug_loc 3417622 3417622 0 0.0
.debug_ranges 372072 372072 0 0.0
.debug_str 3575802 3575802 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107568 107568 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 573412 573412 0 0.0
.symtab 173472 173472 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
954682 954684 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1280415 1280415 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77841 77841 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1704359 1704359 0 0.0
.debug_aranges 142616 142616 0 0.0
.debug_frame 520296 520296 0 0.0
.debug_info 45117269 45117269 0 0.0
.debug_line 5683184 5683184 0 0.0
.debug_loc 3614576 3614576 0 0.0
.debug_ranges 395848 395848 0 0.0
.debug_str 3979339 3979339 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122208 122208 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 634476 634476 0 0.0
.symtab 191936 191936 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1032094 1032094 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679935 679935 0 0.0
(read/write) 171160 171160 0 0.0
.bss 80788 80788 0 0.0
.data 3388 3388 0 0.0
.rodata 88319 88319 0 0.0
.text 591300 591300 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643279 643279 0 0.0
(read/write) 157500 157500 0 0.0
.bss 79996 79996 0 0.0
.data 3388 3388 0 0.0
.rodata 78231 78231 0 0.0
.text 564728 564728 0 0.0
lock-ftd LP_CC2652R7 (read only) 676447 676447 0 0.0
(read/write) 172016 172016 0 0.0
.bss 78244 78244 0 0.0
.data 3316 3316 0 0.0
.rodata 76679 76679 0 0.0
.text 599288 599288 0 0.0
lock-mtd LP_CC2652R7 (read only) 662947 662947 0 0.0
(read/write) 180772 180772 0 0.0
.bss 73500 73500 0 0.0
.data 3316 3316 0 0.0
.rodata 103299 103299 0 0.0
.text 559168 559168 0 0.0
pump-app LP_CC2652R7 (read only) 689387 689387 0 0.0
(read/write) 159796 159796 0 0.0
.bss 78196 78196 0 0.0
.data 3280 3280 0 0.0
.rodata 90931 90931 0 0.0
.text 597976 597976 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674571 674571 0 0.0
(read/write) 174740 174740 0 0.0
.bss 78324 78324 0 0.0
.data 3304 3304 0 0.0
.rodata 86931 86931 0 0.0
.text 587160 587160 0 0.0
shell LP_CC2652R7 (read only) 671198 671198 0 0.0
(read/write) 181968 181968 0 0.0
.bss 82860 82860 0 0.0
.data 3384 3384 0 0.0
.rodata 85070 85070 0 0.0
.text 585816 585816 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 642217 642217 0 0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934242 0 0.0
.debug_aranges 87448 87448 0 0.0
.debug_frame 300212 300212 0 0.0
.debug_info 20360345 20360345 0 0.0
.debug_line 2661062 2661062 0 0.0
.debug_loc 2797107 2797107 0 0.0
.debug_ranges 281744 281744 0 0.0
.debug_str 3019502 3019502 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 0 0 0 0.0
534392 534392 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12060708 12060708 0 0.0
(read/write) 729224 729224 0 0.0
.bss 34136 34136 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 671552 671552 0 0.0
.dynamic 560 560 0 0.0
.got 15328 15328 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 585780 585748 -32 -0.0
.text 9744372 9744404 32 0.0
thermostat-no-ble arm64 (read only) 2516220 2516220 0 0.0
(read/write) 145096 145096 0 0.0
.bss 56312 56312 0 0.0
.data 1832 1832 0 0.0
.data.rel.ro 77568 77568 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151320 151320 0 0.0
.text 2102752 2102752 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150636 1150628 -8 -0.0
.bss 99820 99820 0 0.0
.data 852 852 0 0.0
.text 597732 597724 -8 -0.0
lock-app qpg6105+debug (read/write) 1118204 1118204 0 0.0
.bss 96316 96316 0 0.0
.data 864 864 0 0.0
.text 565304 565304 0 0.0

@github-actions
Copy link

PR #25176: Size comparison from 738205d to c0d03bd

Increases (1 build for cc32xx)
platform target config section 738205d c0d03bd change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20360343 20360344 1 0.0
Full report (1 build for cc32xx)
platform target config section 738205d c0d03bd change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642217 642217 0 0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934242 0 0.0
.debug_aranges 87448 87448 0 0.0
.debug_frame 300212 300212 0 0.0
.debug_info 20360343 20360344 1 0.0
.debug_line 2661062 2661062 0 0.0
.debug_loc 2797107 2797107 0 0.0
.debug_ranges 281744 281744 0 0.0
.debug_str 3019502 3019502 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534392 534392 0 0.0

@vivien-apple vivien-apple force-pushed the DiscoverOnceRewrite branch 2 times, most recently from 7632b64 to daee6ac Compare February 18, 2023 15:53
@github-actions
Copy link

PR #25176: Size comparison from 738205d to daee6ac

Increases (1 build for cc32xx)
platform target config section 738205d daee6ac change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20360343 20360344 1 0.0
Full report (1 build for cc32xx)
platform target config section 738205d daee6ac change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642217 642217 0 0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934242 0 0.0
.debug_aranges 87448 87448 0 0.0
.debug_frame 300212 300212 0 0.0
.debug_info 20360343 20360344 1 0.0
.debug_line 2661062 2661062 0 0.0
.debug_loc 2797107 2797107 0 0.0
.debug_ranges 281744 281744 0 0.0
.debug_str 3019502 3019502 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534392 534392 0 0.0

@github-actions
Copy link

PR #25176: Size comparison from 738205d to 0da9eeb

Increases (1 build for cc32xx)
platform target config section 738205d 0da9eeb change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20360343 20360344 1 0.0
Full report (1 build for cc32xx)
platform target config section 738205d 0da9eeb change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642217 642217 0 0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934242 0 0.0
.debug_aranges 87448 87448 0 0.0
.debug_frame 300212 300212 0 0.0
.debug_info 20360343 20360344 1 0.0
.debug_line 2661062 2661062 0 0.0
.debug_loc 2797107 2797107 0 0.0
.debug_ranges 281744 281744 0 0.0
.debug_str 3019502 3019502 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534392 534392 0 0.0

@github-actions
Copy link

PR #25176: Size comparison from 04adc52 to 48c0b90

Decreases (1 build for cc32xx)
platform target config section 04adc52 48c0b90 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20360287 20360286 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 04adc52 48c0b90 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642209 642209 0 0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934242 0 0.0
.debug_aranges 87448 87448 0 0.0
.debug_frame 300212 300212 0 0.0
.debug_info 20360287 20360286 -1 -0.0
.debug_line 2661052 2661052 0 0.0
.debug_loc 2797120 2797120 0 0.0
.debug_ranges 281744 281744 0 0.0
.debug_str 3019502 3019502 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105713 105713 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534376 534376 0 0.0

@vivien-apple vivien-apple merged commit dbc35c0 into project-chip:master Feb 21, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@vivien-apple
Rewrite discover-once to really stop right after the first PASE sessi…
360cd5f 
…on failure (project-chip#25176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@wqx6 wqx6 wqx6 approved these changes

@msandstedt msandstedt msandstedt approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees

@vivien-apple vivien-apple

Labels
app controller darwin examples platform review - approved tests tools
Projects
None yet
Milestone
No milestone
5 participants
@vivien-apple @msandstedt @wqx6 @woody-apple @bzbarsky-apple