Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle an (invalid) empty InvokeResponses list. #25197

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Handle an (invalid) empty InvokeResponses list. #25197

merged 1 commit into from
Feb 23, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Without this change, InvokeInteraction could end up not calling either of its callbacks if the server responded with an empty InvokeResponses list.

@bzbarsky-apple
Handle an (invalid) empty InvokeResponses list.
385a6ed 
Without this change, InvokeInteraction could end up not calling either
of its callbacks if the server responded with an empty InvokeResponses
list.
@github-actions
Copy link

PR #25197: Size comparison from e0e3225 to 385a6ed

Increases (1 build for cc32xx)
platform target config section e0e3225 385a6ed change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20256439 20257469 1030 0.0
.debug_line 2656005 2656380 375 0.0
.debug_loc 2796891 2797617 726 0.0
.debug_ranges 281688 281832 144 0.1
Full report (1 build for cc32xx)
platform target config section e0e3225 385a6ed change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642529 642529 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930533 930533 0 0.0
.debug_aranges 87392 87392 0 0.0
.debug_frame 300100 300100 0 0.0
.debug_info 20256439 20257469 1030 0.0
.debug_line 2656005 2656380 375 0.0
.debug_loc 2796891 2797617 726 0.0
.debug_ranges 281688 281832 144 0.1
.debug_str 3018892 3018892 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377598 377598 0 0.0
.symtab 256144 256144 0 0.0
.text 534588 534588 0 0.0

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Feb 20, 2023
@bzbarsky-apple
Simplify the logic in invokeCommandWithEndpointID in MTRBaseDevice.
fc3824f 
* Fix MTRInvokeCallback to guarantee callback delivery, similar to
  project-chip#25197
* Fix NSObjectCommandCallback to guarantee callback delivery and ensure that it
  only calls a single callback.
* Simplify the logic in invokeCommandWithEndpointID by relying on the
  now-enforced invariants around callbacks.
* Document how errors are delivered for invokeCommandWithEndpointID.
@bzbarsky-apple bzbarsky-apple mentioned this pull request Feb 20, 2023
Merged
@pullapprove pullapprove bot requested a review from nivi-apple February 20, 2023 20:06
bzbarsky-apple added a commit that referenced this pull request Feb 22, 2023
@bzbarsky-apple
Simplify the logic in invokeCommandWithEndpointID in MTRBaseDevice. (#…
c6cadc8 
…25199)

* Fix MTRInvokeCallback to guarantee callback delivery, similar to
  #25197
* Fix NSObjectCommandCallback to guarantee callback delivery and ensure that it
  only calls a single callback.
* Simplify the logic in invokeCommandWithEndpointID by relying on the
  now-enforced invariants around callbacks.
* Document how errors are delivered for invokeCommandWithEndpointID.
@bzbarsky-apple bzbarsky-apple merged commit 92efde8 into project-chip:master Feb 23, 2023
@bzbarsky-apple bzbarsky-apple deleted the handle-invalid-empty-command-response-list branch February 23, 2023 16:02
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this pull request Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Simplify the logic in invokeCommandWithEndpointID in MTRBaseDevice. (…
8096b16 
…#25199)

* Fix MTRInvokeCallback to guarantee callback delivery, similar to
  project-chip/connectedhomeip#25197
* Fix NSObjectCommandCallback to guarantee callback delivery and ensure that it
  only calls a single callback.
* Simplify the logic in invokeCommandWithEndpointID by relying on the
  now-enforced invariants around callbacks.
* Document how errors are delivered for invokeCommandWithEndpointID.
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this pull request Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Simplify the logic in invokeCommandWithEndpointID in MTRBaseDevice. (…
5ed3187 
…#25199)

* Fix MTRInvokeCallback to guarantee callback delivery, similar to
  project-chip/connectedhomeip#25197
* Fix NSObjectCommandCallback to guarantee callback delivery and ensure that it
  only calls a single callback.
* Simplify the logic in invokeCommandWithEndpointID by relying on the
  now-enforced invariants around callbacks.
* Document how errors are delivered for invokeCommandWithEndpointID.
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Simplify the logic in invokeCommandWithEndpointID in MTRBaseDevice. (p…
253a499 
…roject-chip#25199)

* Fix MTRInvokeCallback to guarantee callback delivery, similar to
  project-chip#25197
* Fix NSObjectCommandCallback to guarantee callback delivery and ensure that it
  only calls a single callback.
* Simplify the logic in invokeCommandWithEndpointID by relying on the
  now-enforced invariants around callbacks.
* Document how errors are delivered for invokeCommandWithEndpointID.
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Handle an (invalid) empty InvokeResponses list. (project-chip#25197)
705efbf 
Without this change, InvokeInteraction could end up not calling either
of its callbacks if the server responded with an empty InvokeResponses
list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @andy31415 @yufengwangca @jmartinez-silabs