Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EFR32] Add to flake8 in workflow and fix python files (part #25193) #25283

Merged
merged 1 commit into from
Feb 28, 2023
+6 −7
Merged

[EFR32] Add to flake8 in workflow and fix python files (part #25193) #25283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ exclude = third_party
src/test_driver/mbed/*
src/test_driver/linux-cirque/*
src/test_driver/esp32/*
src/test_driver/efr32/*
build/chip/java/tests/*
build/chip/linux/*
build/config/linux/*
Expand All @@ -29,7 +28,6 @@ exclude = third_party
scripts/build/builders/android.py
scripts/build/builders/bouffalolab.py
scripts/build/builders/cc13x2x7_26x2x7.py
scripts/build/builders/efr32.py
scripts/build/builders/esp32.py
scripts/build/builders/genio.py
scripts/build/builders/gn.py
Expand Down
9 changes: 5 additions & 4 deletions scripts/build/builders/efr32.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,16 +167,16 @@ def __init__(self,
if chip_build_libshell:
self.extra_gn_options.append('chip_build_libshell=true')

if chip_logging == False:
if chip_logging is False:
self.extra_gn_options.append('chip_logging=false')

if chip_openthread_ftd == False:
if chip_openthread_ftd is False:
self.extra_gn_options.append('chip_openthread_ftd=false')

if enable_heap_monitoring:
self.extra_gn_options.append('enable_heap_monitoring=true')

if enable_openthread_cli == False:
if enable_openthread_cli is False:
self.extra_gn_options.append('enable_openthread_cli=false')

if show_qr_code:
Expand Down Expand Up @@ -208,7 +208,8 @@ def __init__(self,

if enable_ot_coap_lib:
self.extra_gn_options.append(
'use_silabs_thread_lib=true chip_openthread_target="../silabs:ot-efr32-cert" use_thread_coap_lib=true openthread_external_platform=""')
'use_silabs_thread_lib=true chip_openthread_target="../silabs:ot-efr32-cert" '
'use_thread_coap_lib=true openthread_external_platform=""')

if not no_version:
shortCommitSha = subprocess.check_output(
Expand Down
2 changes: 1 addition & 1 deletion src/test_driver/efr32/py/nl_test_runner/nl_test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def read(): return serial_device.read(8192)
def runner(client) -> int:
""" Run the tests"""
def on_error_callback(call_object, error):
raise Exception("Error running test RPC: {}".format(status))
raise Exception("Error running test RPC: {}".format(error))

rpc = client.client.channel(1).rpcs.chip.rpc.NlTest.Run
invoke = rpc.invoke(rpc.request(), on_error=on_error_callback)
Expand Down