Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose provisional EventList in Darwin APIs yet. #25295

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Don't expose provisional EventList in Darwin APIs yet. #25295

merged 1 commit into from
Feb 24, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Fixes a template bug where we were doing incorrect wasRemoved checks.

@bzbarsky-apple
Don't expose provisional EventList in Darwin APIs yet.
c8b30a7 
Fixes a template bug where we were doing incorrect wasRemoved checks.
@github-actions
Copy link

github-actions bot commented Feb 24, 2023 •
edited
Loading

PR #25295: Size comparison from 7775bec to c8b30a7

Increases (5 builds for cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
platform target config section 7775bec c8b30a7 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 674763 674771 8 0.0
.text 587472 587480 8 0.0
esp32 all-clusters-app c3devkit (read only) 1050612 1050614 2 0.0
.flash.text 1050612 1050614 2 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 807248 807252 4 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22860281 22860282 1 0.0
telink thermostat tlsr9518adk80d text 594504 594506 2 0.0
Decreases (10 builds for bl602, bl702, cc13x2_26x2, cc32xx, psoc6, telink)
platform target config section 7775bec c8b30a7 change % change
bl602 lighting-app bl602 (read/write) 1349822 1349814 -8 -0.0
.text 1026036 1026032 -4 -0.0
bl602+rpc (read/write) 1395246 1395238 -8 -0.0
.text 1056970 1056968 -2 -0.0
bl702 lighting-app bl702 .debug_info 40596446 40596445 -1 -0.0
.text 955380 955378 -2 -0.0
bl702+rpc .debug_info 45008426 45008425 -1 -0.0
.text 1030408 1030406 -2 -0.0
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 174556 174548 -8 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20257010 20257009 -1 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27973155 27973154 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 23112169 23112167 -2 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1016912 1016904 -8 -0.0
text 687530 687528 -2 -0.0
contact-sensor-app tlsr9518adk80d (read/write) 856168 856160 -8 -0.0
text 579062 579058 -4 -0.0
Full report (43 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 7775bec c8b30a7 change % change
bl602 lighting-app bl602 (read/write) 1349822 1349814 -8 -0.0
.bss 94674 94674 0 0.0
.data 9752 9752 0 0.0
.text 1026036 1026032 -4 -0.0
bl602+rpc (read/write) 1395246 1395238 -8 -0.0
.bss 102722 102722 0 0.0
.data 10144 10144 0 0.0
.text 1056970 1056968 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1188171 1188171 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69785 69785 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4080 4080 0 0.0
.debug_abbrev 1551800 1551800 0 0.0
.debug_aranges 134272 134272 0 0.0
.debug_frame 492272 492272 0 0.0
.debug_info 40596446 40596445 -1 -0.0
.debug_line 5278165 5278165 0 0.0
.debug_loc 3416695 3416695 0 0.0
.debug_ranges 372056 372056 0 0.0
.debug_str 3580026 3580026 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107744 107744 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574257 574257 0 0.0
.symtab 173632 173632 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
955380 955378 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1278375 1278375 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77833 77833 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4624 4624 0 0.0
.debug_abbrev 1700009 1700009 0 0.0
.debug_aranges 142512 142512 0 0.0
.debug_frame 519960 519960 0 0.0
.debug_info 45008426 45008425 -1 -0.0
.debug_line 5676926 5676926 0 0.0
.debug_loc 3613417 3613417 0 0.0
.debug_ranges 395832 395832 0 0.0
.debug_str 3983563 3983563 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121840 121840 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635274 635274 0 0.0
.symtab 191968 191968 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1030408 1030406 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 680367 680367 0 0.0
(read/write) 170704 170704 0 0.0
.bss 80764 80764 0 0.0
.data 3352 3352 0 0.0
.rodata 88335 88335 0 0.0
.text 591716 591716 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643503 643503 0 0.0
(read/write) 157432 157432 0 0.0
.bss 79964 79964 0 0.0
.data 3352 3352 0 0.0
.rodata 78199 78199 0 0.0
.text 564984 564984 0 0.0
lock-ftd LP_CC2652R7 (read only) 676591 676591 0 0.0
(read/write) 171848 171848 0 0.0
.bss 78220 78220 0 0.0
.data 3316 3316 0 0.0
.rodata 76519 76519 0 0.0
.text 599592 599592 0 0.0
lock-mtd LP_CC2652R7 (read only) 663371 663371 0 0.0
(read/write) 180324 180324 0 0.0
.bss 73476 73476 0 0.0
.data 3316 3316 0 0.0
.rodata 103363 103363 0 0.0
.text 559528 559528 0 0.0
pump-app LP_CC2652R7 (read only) 689819 689819 0 0.0
(read/write) 159364 159364 0 0.0
.bss 78196 78196 0 0.0
.data 3280 3280 0 0.0
.rodata 90923 90923 0 0.0
.text 598416 598416 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674763 674771 8 0.0
(read/write) 174556 174548 -8 -0.0
.bss 78332 78332 0 0.0
.data 3304 3304 0 0.0
.rodata 86811 86811 0 0.0
.text 587472 587480 8 0.0
shell LP_CC2652R7 (read only) 671782 671782 0 0.0
(read/write) 181360 181360 0 0.0
.bss 82836 82836 0 0.0
.data 3348 3348 0 0.0
.rodata 85230 85230 0 0.0
.text 586240 586240 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930133 930133 0 0.0
.debug_aranges 87304 87304 0 0.0
.debug_frame 299872 299872 0 0.0
.debug_info 20257010 20257009 -1 -0.0
.debug_line 2656183 2656183 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281792 281792 0 0.0
.debug_str 3023459 3023459 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 0 0 0 0.0
534788 534788 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586186 586186 0 0.0
.app_xip_area 463076 463076 0 0.0
.bss 65552 65552 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590170 590170 0 0.0
.app_xip_area 461764 461764 0 0.0
.bss 70840 70840 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551214 551214 0 0.0
.app_xip_area 433600 433600 0 0.0
.bss 60096 60096 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1041560 1041560 0 0.0
.bss 181484 181484 0 0.0
.data 2048 2048 0 0.0
.text 858008 858008 0 0.0
BRD4187C (read/write) 1026000 1026000 0 0.0
.bss 150392 150392 0 0.0
.data 2684 2684 0 0.0
.text 848328 848328 0 0.0
lock-app BRD4161A+wf200 (read/write) 1068680 1068680 0 0.0
.bss 153020 153020 0 0.0
.data 2056 2056 0 0.0
.text 913584 913584 0 0.0
window-app BRD4187C (read/write) 1141328 1141328 0 0.0
.bss 134816 134816 0 0.0
.data 2576 2576 0 0.0
.text 979340 979340 0 0.0
esp32 all-clusters-app c3devkit (read only) 1050612 1050614 2 0.0
(read/write) 1585514 1585514 0 0.0
.dram0.bss 77808 77808 0 0.0
.dram0.data 13752 13752 0 0.0
.flash.rodata 222192 222192 0 0.0
.flash.text 1050612 1050614 2 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1102179 1102179 0 0.0
(read/write) 501587 501587 0 0.0
.dram0.bss 82848 82848 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 250928 250928 0 0.0
.flash.text 1096795 1096795 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 670184 670184 0 0.0
.bss 77556 77556 0 0.0
.data 2204 2204 0 0.0
.text 571312 571312 0 0.0
light k32w0+release (read/write) 669260 669260 0 0.0
.bss 77236 77236 0 0.0
.data 2192 2192 0 0.0
.text 570720 570720 0 0.0
lock k32w0+release (read/write) 625904 625904 0 0.0
.bss 75364 75364 0 0.0
.data 2136 2136 0 0.0
.text 545676 545676 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12106260 12106260 0 0.0
(read/write) 732616 732616 0 0.0
.bss 34136 34136 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 674896 674896 0 0.0
.dynamic 560 560 0 0.0
.got 15368 15368 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 586868 586868 0 0.0
.text 9780740 9780740 0 0.0
thermostat-no-ble arm64 (read only) 2515868 2515868 0 0.0
(read/write) 145064 145064 0 0.0
.bss 56328 56328 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77568 77568 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150552 150552 0 0.0
.text 2103248 2103248 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467168 2467168 0 0.0
.bss 215788 215788 0 0.0
.data 5880 5880 0 0.0
.text 1429812 1429812 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1165520 1165520 0 0.0
bss 143423 143423 0 0.0
rodata 135004 135004 0 0.0
text 807248 807252 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1370708 1370708 0 0.0
bss 105886 105886 0 0.0
rodata 212400 212400 0 0.0
text 766912 766912 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1110532 1110532 0 0.0
bss 142579 142579 0 0.0
rodata 111856 111856 0 0.0
text 776384 776384 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841016 841016 0 0.0
(read/write) 1761188 1761188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189688 189688 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1253498 1253498 0 0.0
.debug_aranges 111424 111424 0 0.0
.debug_frame 374468 374468 0 0.0
.debug_info 27973155 27973154 -1 -0.0
.debug_line 3791300 3791300 0 0.0
.debug_loc 3693548 3693548 0 0.0
.debug_ranges 363608 363608 0 0.0
.debug_str 3532674 3532674 0 0.0
.heap 841016 841016 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 580891 580891 0 0.0
.symtab 425632 425632 0 0.0
.text 1560472 1560472 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841824 841824 0 0.0
(read/write) 1701396 1701396 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188888 188888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1238831 1238831 0 0.0
.debug_aranges 110656 110656 0 0.0
.debug_frame 376804 376804 0 0.0
.debug_info 27517715 27517715 0 0.0
.debug_line 3798799 3798799 0 0.0
.debug_loc 3676750 3676750 0 0.0
.debug_ranges 361544 361544 0 0.0
.debug_str 3519796 3519796 0 0.0
.heap 841824 841824 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 540600 540600 0 0.0
.symtab 410544 410544 0 0.0
.text 1501488 1501488 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850088 850088 0 0.0
(read/write) 1615108 1615108 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180792 180792 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1074186 1074186 0 0.0
.debug_aranges 102864 102864 0 0.0
.debug_frame 347092 347092 0 0.0
.debug_info 22860281 22860282 1 0.0
.debug_line 3351568 3351568 0 0.0
.debug_loc 3352031 3352031 0 0.0
.debug_ranges 320064 320064 0 0.0
.debug_str 3318558 3318558 0 0.0
.heap 850088 850088 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476317 476317 0 0.0
.symtab 378528 378528 0 0.0
.text 1423464 1423464 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845112 845112 0 0.0
(read/write) 1648956 1648956 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185752 185752 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1076130 1076130 0 0.0
.debug_aranges 103264 103264 0 0.0
.debug_frame 348852 348852 0 0.0
.debug_info 23112169 23112167 -2 -0.0
.debug_line 3353826 3353826 0 0.0
.debug_loc 3376714 3376714 0 0.0
.debug_ranges 322616 322616 0 0.0
.debug_str 3337369 3337369 0 0.0
.heap 845112 845112 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 480041 480041 0 0.0
.symtab 380704 380704 0 0.0
.text 1452336 1452336 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151340 1151340 0 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598436 598436 0 0.0
lock-app qpg6105+debug (read/write) 1118540 1118540 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565640 565640 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1016912 1016904 -8 -0.0
bss 97760 97760 0 0.0
text 687530 687528 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 952120 952120 0 0.0
bss 96812 96812 0 0.0
text 648786 648786 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 856168 856160 -8 -0.0
bss 88976 88976 0 0.0
text 579062 579058 -4 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 872020 872020 0 0.0
bss 89064 89064 0 0.0
text 593198 593198 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950592 950592 0 0.0
bss 97184 97184 0 0.0
text 659524 659524 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883612 883612 0 0.0
bss 89988 89988 0 0.0
text 603136 603136 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875936 875936 0 0.0
bss 90456 90456 0 0.0
text 594504 594506 2 0.0

@woody-apple woody-apple enabled auto-merge (squash) February 24, 2023 14:32
@woody-apple woody-apple merged commit 53142c7 into project-chip:master Feb 24, 2023
@bzbarsky-apple bzbarsky-apple deleted the event-list-provisional-darwin branch February 24, 2023 14:57
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Don't expose provisional EventList in Darwin APIs yet. (project-chip#…
7b59ea6 
…25295)

Fixes a template bug where we were doing incorrect wasRemoved checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @woody-apple