Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable -Wconversion in lib/dnssd. #25328

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Enable -Wconversion in lib/dnssd. #25328

merged 1 commit into from
Feb 27, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the lib label Feb 26, 2023
@github-actions
Copy link

PR #25328: Size comparison from 3b80154 to 701847a

Decreases (1 build for qpg)
platform target config section 3b80154 701847a change % change
qpg lock-app qpg6105+debug (read/write) 1118500 1118492 -8 -0.0
.text 565600 565592 -8 -0.0
Full report (2 builds for qpg)
platform target config section 3b80154 701847a change % change
qpg lighting-app qpg6105+debug (read/write) 1151284 1151284 0 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598380 598380 0 0.0
lock-app qpg6105+debug (read/write) 1118500 1118492 -8 -0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565600 565592 -8 -0.0

@github-actions
Copy link

github-actions bot commented Feb 26, 2023 •
edited
Loading

PR #25328: Size comparison from 3b80154 to 960c0de

Increases (4 builds for cc13x2_26x2)
platform target config section 3b80154 960c0de change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 171896 171904 8 0.0
lock-mtd LP_CC2652R7 (read/write) 180364 180372 8 0.0
pump-app LP_CC2652R7 (read only) 689771 689779 8 0.0
.rodata 90923 90931 8 0.0
shell LP_CC2652R7 (read/write) 181384 181392 8 0.0
Decreases (6 builds for cc13x2_26x2, qpg)
platform target config section 3b80154 960c0de change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 643455 643447 -8 -0.0
.text 564944 564936 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 676543 676535 -8 -0.0
.text 599544 599536 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 663331 663323 -8 -0.0
.text 559488 559480 -8 -0.0
pump-app LP_CC2652R7 (read/write) 159412 159404 -8 -0.0
shell LP_CC2652R7 (read only) 671758 671750 -8 -0.0
.text 586224 586216 -8 -0.0
qpg lock-app qpg6105+debug (read/write) 1118500 1118492 -8 -0.0
.text 565600 565592 -8 -0.0
Full report (12 builds for cc13x2_26x2, k32w, qpg)
platform target config section 3b80154 960c0de change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 680303 680303 0 0.0
(read/write) 170768 170768 0 0.0
.bss 80764 80764 0 0.0
.data 3352 3352 0 0.0
.rodata 88319 88319 0 0.0
.text 591668 591668 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643455 643447 -8 -0.0
(read/write) 157432 157432 0 0.0
.bss 79964 79964 0 0.0
.data 3352 3352 0 0.0
.rodata 78191 78191 0 0.0
.text 564944 564936 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 676543 676535 -8 -0.0
(read/write) 171896 171904 8 0.0
.bss 78220 78220 0 0.0
.data 3316 3316 0 0.0
.rodata 76519 76519 0 0.0
.text 599544 599536 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 663331 663323 -8 -0.0
(read/write) 180364 180372 8 0.0
.bss 73476 73476 0 0.0
.data 3316 3316 0 0.0
.rodata 103363 103363 0 0.0
.text 559488 559480 -8 -0.0
pump-app LP_CC2652R7 (read only) 689771 689779 8 0.0
(read/write) 159412 159404 -8 -0.0
.bss 78196 78196 0 0.0
.data 3280 3280 0 0.0
.rodata 90923 90931 8 0.0
.text 598368 598368 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674731 674731 0 0.0
(read/write) 174588 174588 0 0.0
.bss 78332 78332 0 0.0
.data 3304 3304 0 0.0
.rodata 86803 86803 0 0.0
.text 587448 587448 0 0.0
shell LP_CC2652R7 (read only) 671758 671750 -8 -0.0
(read/write) 181384 181392 8 0.0
.bss 82836 82836 0 0.0
.data 3348 3348 0 0.0
.rodata 85222 85222 0 0.0
.text 586224 586216 -8 -0.0
k32w contact k32w0+release (read/write) 670136 670136 0 0.0
.bss 77556 77556 0 0.0
.data 2204 2204 0 0.0
.text 571264 571264 0 0.0
light k32w0+release (read/write) 669204 669204 0 0.0
.bss 77236 77236 0 0.0
.data 2192 2192 0 0.0
.text 570664 570664 0 0.0
lock k32w0+release (read/write) 625848 625848 0 0.0
.bss 75364 75364 0 0.0
.data 2136 2136 0 0.0
.text 545620 545620 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151284 1151284 0 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598380 598380 0 0.0
lock-app qpg6105+debug (read/write) 1118500 1118492 -8 -0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565600 565592 -8 -0.0

@github-actions
Copy link

PR #25328: Size comparison from 3b80154 to b85d6f9

Increases (1 build for cc32xx)
platform target config section 3b80154 b85d6f9 change % change
cc32xx lock CC3235SF_LAUNCHXL (read/write) 203672 203688 16 0.0
.bss 197072 197088 16 0.0
.debug_abbrev 930077 930109 32 0.0
.debug_info 20256038 20256091 53 0.0
.debug_line 2655900 2655917 17 0.0
Decreases (1 build for cc32xx)
platform target config section 3b80154 b85d6f9 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642609 642601 -8 -0.0
.debug_loc 2797195 2797182 -13 -0.0
.debug_str 3023188 3023082 -106 -0.0
.text 534724 534716 -8 -0.0
Full report (1 build for cc32xx)
platform target config section 3b80154 b85d6f9 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642609 642601 -8 -0.0
(read/write) 203672 203688 16 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197088 16 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930109 32 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256038 20256091 53 0.0
.debug_line 2655900 2655917 17 0.0
.debug_loc 2797195 2797182 -13 -0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023188 3023082 -106 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105761 105761 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256224 256224 0 0.0
.text 534724 534716 -8 -0.0

@github-actions
Copy link

PR #25328: Size comparison from 3b80154 to 2c2ac9b

Increases (5 builds for cc32xx, linux, mbed, nrfconnect)
platform target config section 3b80154 2c2ac9b change % change
cc32xx lock CC3235SF_LAUNCHXL (read/write) 203672 203688 16 0.0
.bss 197072 197088 16 0.0
.debug_abbrev 930077 930109 32 0.0
.debug_info 20256038 20256090 52 0.0
.debug_line 2655900 2655917 17 0.0
linux chip-tool-ipv6only arm64 (read only) 12123636 12123972 336 0.0
(read/write) 732808 732824 16 0.0
.bss 34280 34296 16 0.0
.rodata 586900 586964 64 0.0
.text 9797972 9798244 272 0.0
thermostat-no-ble arm64 (read only) 2516748 2516860 112 0.0
(read/write) 145112 145128 16 0.0
.bss 56328 56344 16 0.0
.rodata 150536 150600 64 0.0
.text 2104064 2104112 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release .bss 215788 215804 16 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp bss 105886 105902 16 0.0
Decreases (2 builds for cc32xx, nrfconnect)
platform target config section 3b80154 2c2ac9b change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642609 642601 -8 -0.0
.debug_loc 2797195 2797182 -13 -0.0
.debug_str 3023188 3023082 -106 -0.0
.text 534724 534716 -8 -0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 767508 767504 -4 -0.0
Full report (7 builds for cc32xx, linux, mbed, nrfconnect)
platform target config section 3b80154 2c2ac9b change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642609 642601 -8 -0.0
(read/write) 203672 203688 16 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197088 16 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930109 32 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256038 20256090 52 0.0
.debug_line 2655900 2655917 17 0.0
.debug_loc 2797195 2797182 -13 -0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023188 3023082 -106 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105761 105761 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256224 256224 0 0.0
.text 534724 534716 -8 -0.0
linux chip-tool-ipv6only arm64 (read only) 12123636 12123972 336 0.0
(read/write) 732808 732824 16 0.0
.bss 34280 34296 16 0.0
.data 3008 3008 0 0.0
.data.rel.ro 674936 674936 0 0.0
.dynamic 560 560 0 0.0
.got 15376 15376 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 586900 586964 64 0.0
.text 9797972 9798244 272 0.0
thermostat-no-ble arm64 (read only) 2516748 2516860 112 0.0
(read/write) 145112 145128 16 0.0
.bss 56328 56344 16 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77616 77616 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150536 150600 64 0.0
.text 2104064 2104112 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467096 2467096 0 0.0
.bss 215788 215804 16 0.0
.data 5880 5880 0 0.0
.text 1429740 1429740 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1167376 1167376 0 0.0
bss 143423 143423 0 0.0
rodata 136188 136188 0 0.0
text 807924 807924 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1112396 1112396 0 0.0
bss 142579 142579 0 0.0
rodata 113032 113032 0 0.0
text 777072 777072 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1372476 1372476 0 0.0
bss 105886 105902 16 0.0
rodata 213576 213576 0 0.0
text 767508 767504 -4 -0.0

@github-actions
Copy link

PR #25328: Size comparison from 3b80154 to 2264eaa

Increases (2 builds for cc32xx, mbed)
platform target config section 3b80154 2264eaa change % change
cc32xx lock CC3235SF_LAUNCHXL (read/write) 203672 203688 16 0.0
.bss 197072 197088 16 0.0
.debug_abbrev 930077 930109 32 0.0
.debug_info 20256038 20256091 53 0.0
.debug_line 2655900 2655917 17 0.0
mbed lock-app CY8CPROTO_062_4343W+release .bss 215788 215804 16 0.0
Decreases (1 build for cc32xx)
platform target config section 3b80154 2264eaa change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642609 642601 -8 -0.0
.debug_loc 2797195 2797182 -13 -0.0
.debug_str 3023188 3023082 -106 -0.0
.text 534724 534716 -8 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 3b80154 2264eaa change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642609 642601 -8 -0.0
(read/write) 203672 203688 16 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197088 16 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930109 32 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256038 20256091 53 0.0
.debug_line 2655900 2655917 17 0.0
.debug_loc 2797195 2797182 -13 -0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023188 3023082 -106 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105761 105761 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256224 256224 0 0.0
.text 534724 534716 -8 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467096 2467096 0 0.0
.bss 215788 215804 16 0.0
.data 5880 5880 0 0.0
.text 1429740 1429740 0 0.0

@github-actions github-actions bot removed the platform label Feb 27, 2023
@github-actions
Copy link

PR #25328: Size comparison from 753fa1c to 943ca81

Increases (1 build for cc32xx)
platform target config section 753fa1c 943ca81 change % change
cc32xx lock CC3235SF_LAUNCHXL (read/write) 203672 203688 16 0.0
.bss 197072 197088 16 0.0
.debug_abbrev 930077 930109 32 0.0
.debug_info 20256037 20256090 53 0.0
.debug_line 2655900 2655917 17 0.0
Decreases (1 build for cc32xx)
platform target config section 753fa1c 943ca81 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642609 642601 -8 -0.0
.debug_loc 2797195 2797182 -13 -0.0
.debug_str 3023188 3023082 -106 -0.0
.text 534724 534716 -8 -0.0
Full report (1 build for cc32xx)
platform target config section 753fa1c 943ca81 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642609 642601 -8 -0.0
(read/write) 203672 203688 16 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197088 16 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930109 32 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256037 20256090 53 0.0
.debug_line 2655900 2655917 17 0.0
.debug_loc 2797195 2797182 -13 -0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023188 3023082 -106 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105761 105761 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256224 256224 0 0.0
.text 534724 534716 -8 -0.0

@bzbarsky-apple bzbarsky-apple enabled auto-merge (squash) February 27, 2023 16:39
@github-actions
Copy link

PR #25328: Size comparison from 511044b to b37bdb0

Increases (1 build for cc32xx)
platform target config section 511044b b37bdb0 change % change
cc32xx lock CC3235SF_LAUNCHXL (read/write) 203672 203688 16 0.0
.bss 197072 197088 16 0.0
.debug_abbrev 930077 930109 32 0.0
.debug_info 20256038 20256091 53 0.0
.debug_line 2655900 2655917 17 0.0
Decreases (1 build for cc32xx)
platform target config section 511044b b37bdb0 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642609 642601 -8 -0.0
.debug_loc 2797195 2797182 -13 -0.0
.debug_str 3023188 3023082 -106 -0.0
.text 534724 534716 -8 -0.0
Full report (1 build for cc32xx)
platform target config section 511044b b37bdb0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642609 642601 -8 -0.0
(read/write) 203672 203688 16 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197088 16 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930109 32 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256038 20256091 53 0.0
.debug_line 2655900 2655917 17 0.0
.debug_loc 2797195 2797182 -13 -0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023188 3023082 -106 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105761 105761 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256224 256224 0 0.0
.text 534724 534716 -8 -0.0

@bzbarsky-apple bzbarsky-apple merged commit 1c18425 into project-chip:master Feb 27, 2023
@bzbarsky-apple bzbarsky-apple deleted the Wconversion-dnssd branch February 27, 2023 18:58
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Enable -Wconversion in lib/dnssd. (project-chip#25328)
75a010a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliffamzn cliffamzn cliffamzn approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@vivien-apple vivien-apple vivien-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bzbarsky-apple @andy31415 @yunhanw-google @vivien-apple @jmartinez-silabs @cliffamzn