Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESP32] Replace undefined variable 'type' with 'service->mType' #25393

Conversation

Jerry-ESP
Copy link
Contributor

There is an undefined variable "type" in the code, it cause build error when use platform mdns.
So I changed the variable to "service->mType"

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

PR #25393: Size comparison from eff5773 to 765c578

Decreases (1 build for cc32xx)
platform target config section eff5773 765c578 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262893 20262891 -2 -0.0
Full report (1 build for cc32xx)
platform target config section eff5773 765c578 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930167 930167 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262893 20262891 -2 -0.0
.debug_line 2657207 2657207 0 0.0
.debug_loc 2799993 2799993 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

@andy31415 andy31415 merged commit 559da24 into project-chip:master Mar 1, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
dbahrdt pushed a commit to Eltako/connectedhomeip that referenced this pull request Aug 28, 2023
dbahrdt added a commit to Eltako/connectedhomeip that referenced this pull request Sep 14, 2023
…#25393) (#4)

Fix build error in case esp-idf's mDNS implementation is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants