Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Implement the trust store delegate API for customized device attestation #25471

Merged
merged 2 commits into from
Mar 7, 2023
Merged

[Java] Implement the trust store delegate API for customized device attestation #25471

merged 2 commits into from
Mar 7, 2023

Conversation

yufengwangca
Copy link
Contributor

This is the continuation work of #24381

Currently, our Java pairing API always use the examples PAAs list to verify the device, this PR implement a Attestation TrustStore Delegate API which allow the vendor to replace the default trust store with their own PAA list

Fix: #24297

Testing
Used Android chip-tool which implemented this delegate and verified the existing path still works
The CI test will be added later after we complete the kotlin conversion in java-matter-controller

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

PR #25471: Size comparison from ce07f52 to 6a2dac2

Decreases (1 build for cc32xx)
platform target config section ce07f52 6a2dac2 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262928 20262927 -1 -0.0
Full report (1 build for cc32xx)
platform target config section ce07f52 6a2dac2 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262928 20262927 -1 -0.0
.debug_line 2657822 2657822 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

@andy31415 andy31415 enabled auto-merge (squash) March 7, 2023 15:57
@andy31415 andy31415 merged commit ab3d680 into project-chip:master Mar 7, 2023
@yufengwangca yufengwangca deleted the pr/java/truststore branch March 7, 2023 17:42
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…ttestation (project-chip#25471)

* [Java]Implement truststore delegate API

* Address the review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Platform] Implement a DeviceAttestationVerifier in Java to allow user to overwrite the DefaultDACVerifier
3 participants