ESP32: Add kDnss initialized event to re-establish binding table #25563

abdulrehmanee12 · 2023-03-08T06:14:15Z

Purpose
InitOTARequestor and InitBindingHandler functions call under kDnss Initialized event to establish CASE section to bind device after reboot

Changes
Add the kDnss Initialized event
Call the InitOTARequestor and InitBindingHandler functions under kDnss initialized event

Test
Tested establish connection after reboot for all the examples on ESP32-C3
Tested establish connection after reboot for lighting-app example on ESP32-H2

CLAassistant · 2023-03-08T06:41:09Z

All committers have signed the CLA.

github-actions · 2023-03-08T07:06:48Z

PR #25563: Size comparison from 536a0d9 to 57a737c

Increases (3 builds for bl702, cc13x2_26x2, nrfconnect)

platform	target	config	section	`536a0d9`	`57a737c`	change
bl702	lighting-app	bl702	.debug_info	40860380	40860381	1
			.text	958468	958470	2
cc13x2_26x2	pump-controller-app	LP_CC2652R7	(read only)	676555	676563	8
			.text	589104	589112	8
nrfconnect	all-clusters-minimal-app	nrf52840dk_nrf52840	text	773456	773460	4

Decreases (3 builds for bl602, cc13x2_26x2)

platform	target	config	section	`536a0d9`	`57a737c`	change	% change
bl602	lighting-app	bl602	.text	1027910	1027908	-2	-0.0
		bl602+rpc	.text	1058844	1058842	-2	-0.0
cc13x2_26x2	pump-controller-app	LP_CC2652R7	(read/write)	172884	172876	-8	-0.0

Full report (23 builds for bl602, bl702, cc13x2_26x2, cc32xx, k32w, linux, mbed, nrfconnect, qpg)

platform	target	config	section	`536a0d9`	`57a737c`	change	% change
bl602	lighting-app	bl602	(read/write)	1351854	1351854	0	0.0
			.bss	94690	94690	0	0.0
			.data	9744	9744	0	0.0
			.text	1027910	1027908	-2	-0.0
		bl602+rpc	(read/write)	`1397302`	`1397302`	0	0.0
			.bss	102738	102738	0	0.0
			.data	10136	10136	0	0.0
			.text	1058844	1058842	-2	-0.0
bl702	lighting-app	bl702		0	0	0	0.0
			(read only)	3358	3358	0	0.0
			(read/write)	1191643	1191643	0	0.0
			.bleromro	6342	6342	0	0.0
			.bleromrw	124	124	0	0.0
			.boot2	292	292	0	0.0
			.bss	69793	69793	0	0.0
			.bss_psram	30160	30160	0	0.0
			.comment	48	48	0	0.0
			.data	4072	4072	0	0.0
			.debug_abbrev	1556782	1556782	0	0.0
			.debug_aranges	134576	134576	0	0.0
			.debug_frame	493312	493312	0	0.0
			.debug_info	40860380	40860381	1	0.0
			.debug_line	5294204	5294204	0	0.0
			.debug_loc	3423730	3423730	0	0.0
			.debug_ranges	373192	373192	0	0.0
			.debug_str	3584830	3584830	0	0.0
			.hbn	536	536	0	0.0
			.hbn_noinit	260	260	0	0.0
			.init	342	342	0	0.0
			.init_array	144	144	0	0.0
			.psram	0	0	0	0.0
			.riscv.attributes	47	47	0	0.0
			.rodata	108048	108048	0	0.0
			.rsvd	2960	2960	0	0.0
			.sha_ocram	72	72	0	0.0
			.shstrtab	304	304	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	576175	576175	0	0.0
			.symtab	174128	174128	0	0.0
			.tcm_data	36	36	0	0.0
			.tcmcode	3358	3358	0	0.0
			.text	958468	958470	2	0.0
		bl702+rpc		0	0	0	0.0
			(read only)	3358	3358	0	0.0
			(read/write)	1282311	1282311	0	0.0
			.bleromro	6342	6342	0	0.0
			.bleromrw	124	124	0	0.0
			.boot2	292	292	0	0.0
			.bss	77841	77841	0	0.0
			.bss_psram	30432	30432	0	0.0
			.comment	48	48	0	0.0
			.data	4616	4616	0	0.0
			.debug_abbrev	`1708897`	`1708897`	0	0.0
			.debug_aranges	142904	142904	0	0.0
			.debug_frame	521256	521256	0	0.0
			.debug_info	45487168	45487168	0	0.0
			.debug_line	5699547	5699547	0	0.0
			.debug_loc	3621745	3621745	0	0.0
			.debug_ranges	397192	397192	0	0.0
			.debug_str	3989026	3989026	0	0.0
			.hbn	536	536	0	0.0
			.hbn_noinit	260	260	0	0.0
			.init	342	342	0	0.0
			.init_array	160	160	0	0.0
			.psram	0	0	0	0.0
			.riscv.attributes	47	47	0	0.0
			.rodata	122256	122256	0	0.0
			.rsvd	2960	2960	0	0.0
			.sha_ocram	72	72	0	0.0
			.shstrtab	304	304	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	637500	637500	0	0.0
			.symtab	192624	192624	0	0.0
			.tcm_data	36	36	0	0.0
			.tcmcode	3358	3358	0	0.0
			.text	1033810	1033810	0	0.0
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	681431	681431	0	0.0
			(read/write)	169664	169664	0	0.0
			.bss	80788	80788	0	0.0
			.data	3352	3352	0	0.0
			.rodata	88527	88527	0	0.0
			.text	592588	592588	0	0.0
	all-clusters-minimal-app	LP_CC2652R7	(read only)	644559	644559	0	0.0
			(read/write)	157456	157456	0	0.0
			.bss	79988	79988	0	0.0
			.data	3352	3352	0	0.0
			.rodata	78399	78399	0	0.0
			.text	565840	565840	0	0.0
	lock-ftd	LP_CC2652R7	(read only)	678375	678375	0	0.0
			(read/write)	170184	170184	0	0.0
			.bss	78340	78340	0	0.0
			.data	3316	3316	0	0.0
			.rodata	76711	76711	0	0.0
			.text	601184	601184	0	0.0
	lock-mtd	LP_CC2652R7	(read only)	664371	664371	0	0.0
			(read/write)	179348	179348	0	0.0
			.bss	73500	73500	0	0.0
			.data	3316	3316	0	0.0
			.rodata	103523	103523	0	0.0
			.text	560368	560368	0	0.0
	pump-app	LP_CC2652R7	(read only)	691611	691611	0	0.0
			(read/write)	157692	157692	0	0.0
			.bss	78316	78316	0	0.0
			.data	3280	3280	0	0.0
			.rodata	91083	91083	0	0.0
			.text	600048	600048	0	0.0
	pump-controller-app	LP_CC2652R7	(read only)	676555	676563	8	0.0
			(read/write)	172884	172876	-8	-0.0
			.bss	78452	78452	0	0.0
			.data	3304	3304	0	0.0
			.rodata	86971	86971	0	0.0
			.text	589104	589112	8	0.0
	shell	LP_CC2652R7	(read only)	672870	672870	0	0.0
			(read/write)	180296	180296	0	0.0
			.bss	82860	82860	0	0.0
			.data	3348	3348	0	0.0
			.rodata	85430	85430	0	0.0
			.text	587128	587128	0	0.0
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	644425	644425	0	0.0
			(read/write)	203688	203688	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197088	197088	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	930235	930235	0	0.0
			.debug_aranges	87344	87344	0	0.0
			.debug_frame	300044	300044	0	0.0
			.debug_info	20267387	20267387	0	0.0
			.debug_line	`2659771`	`2659771`	0	0.0
			.debug_loc	2802807	2802807	0	0.0
			.debug_ranges	282960	282960	0	0.0
			.debug_str	3024017	3024017	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105929	105929	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	378514	378514	0	0.0
			.symtab	256624	256624	0	0.0
			.text	536372	536372	0	0.0
k32w	contact	k32w0+release	(read/write)	673704	673704	0	0.0
			.bss	65372	65372	0	0.0
			.data	2224	2224	0	0.0
			.text	574708	574708	0	0.0
	light	k32w0+release	(read/write)	672748	672748	0	0.0
			.bss	65036	65036	0	0.0
			.data	2212	2212	0	0.0
			.text	574100	574100	0	0.0
	lock	k32w0+release	(read/write)	627164	627164	0	0.0
			.bss	63108	63108	0	0.0
			.data	2136	2136	0	0.0
			.text	546904	546904	0	0.0
linux	chip-tool-ipv6only	arm64	(read only)	12163892	12163892	0	0.0
			(read/write)	733448	733448	0	0.0
			.bss	34296	34296	0	0.0
			.data	3008	3008	0	0.0
			.data.rel.ro	675552	675552	0	0.0
			.dynamic	560	560	0	0.0
			.got	15384	15384	0	0.0
			.init	24	24	0	0.0
			.init_array	216	216	0	0.0
			.rodata	588436	588436	0	0.0
			.text	9834820	9834820	0	0.0
	thermostat-no-ble	arm64	(read only)	`2521876`	`2521876`	0	0.0
			(read/write)	145256	145256	0	0.0
			.bss	56344	56344	0	0.0
			.data	1784	1784	0	0.0
			.data.rel.ro	77712	77712	0	0.0
			.dynamic	560	560	0	0.0
			.got	5368	5368	0	0.0
			.init	24	24	0	0.0
			.init_array	432	432	0	0.0
			.rodata	150864	150864	0	0.0
			.text	2108576	2108576	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2467600	2467600	0	0.0
			.bss	215804	215804	0	0.0
			.data	5880	5880	0	0.0
			.text	1430244	1430244	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	1173100	1173100	0	0.0
			bss	155397	155397	0	0.0
			rodata	132588	132588	0	0.0
			text	804316	804316	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	`1118104`	`1118104`	0	0.0
			bss	154553	154553	0	0.0
			rodata	109416	109416	0	0.0
			text	773456	773460	4	0.0
	all-clusters-app	nrf7002dk_nrf5340_cpuapp	(read only)	4	4	0	0.0
			(read/write)	1432896	1432896	0	0.0
			bss	135137	135137	0	0.0
			rodata	228640	228640	0	0.0
			text	775076	775076	0	0.0
qpg	lighting-app	qpg6105+debug	(read/write)	`1153116`	`1153116`	0	0.0
			.bss	99916	99916	0	0.0
			.data	852	852	0	0.0
			.text	600212	600212	0	0.0
	lock-app	qpg6105+debug	(read/write)	1119524	1119524	0	0.0
			.bss	96308	96308	0	0.0
			.data	864	864	0	0.0
			.text	566624	566624	0	0.0

github-actions · 2023-03-08T09:40:38Z

PR #25563: Size comparison from 536a0d9 to 487183f

Decreases (1 build for cc32xx)

platform	target	config	section	`536a0d9`	`487183f`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20267387	20267386	-1	-0.0

Full report (2 builds for cc32xx, mbed)

platform	target	config	section	`536a0d9`	`487183f`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	644425	644425	0	0.0
			(read/write)	203688	203688	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197088	197088	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	930235	930235	0	0.0
			.debug_aranges	87344	87344	0	0.0
			.debug_frame	300044	300044	0	0.0
			.debug_info	20267387	20267386	-1	-0.0
			.debug_line	`2659771`	`2659771`	0	0.0
			.debug_loc	2802807	2802807	0	0.0
			.debug_ranges	282960	282960	0	0.0
			.debug_str	3024017	3024017	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105929	105929	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	378514	378514	0	0.0
			.symtab	256624	256624	0	0.0
			.text	536372	536372	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2467600	2467600	0	0.0
			.bss	215804	215804	0	0.0
			.data	5880	5880	0	0.0
			.text	1430244	1430244	0	0.0

examples/platform/esp32/ota/OTAHelper.cpp

…/abdulrehmanee12/connectedhomeip into esp32/add_kDnss_initialize_event

github-actions · 2023-03-09T08:59:26Z

PR #25563: Size comparison from a2f83a9 to be76fe6

Increases (1 build for cc32xx)

platform	target	config	section	`a2f83a9`	`be76fe6`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20267468	20267469	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`a2f83a9`	`be76fe6`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	644425	644425	0
			(read/write)	203688	203688	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197088	197088	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930235	930235	0
			.debug_aranges	87344	87344	0
			.debug_frame	300044	300044	0
			.debug_info	20267468	20267469	1
			.debug_line	2659770	2659770	0
			.debug_loc	`2802853`	`2802853`	0
			.debug_ranges	282960	282960	0
			.debug_str	3024079	3024079	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105929	105929	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	378571	378571	0
			.symtab	256624	256624	0
			.text	536372	536372	0

github-actions · 2023-03-09T09:23:06Z

PR #25563: Size comparison from a2f83a9 to 4ab63d2

Full report (2 builds for cc32xx, mbed)

platform	target	config	section	`a2f83a9`	`4ab63d2`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	644425	644425
			(read/write)	203688	203688
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197088	197088
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	930235	930235
			.debug_aranges	87344	87344
			.debug_frame	300044	300044
			.debug_info	20267468	20267468
			.debug_line	2659770	2659770
			.debug_loc	`2802853`	`2802853`
			.debug_ranges	282960	282960
			.debug_str	3024079	3024079
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	105929	105929
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	378571	378571
			.symtab	256624	256624
			.text	536372	536372
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2467664	2467664
			.bss	215804	215804
			.data	5880	5880
			.text	`1430308`	`1430308`

…ject-chip#25563) * ESP32: Add kDnss initialized event to re-establish binding table * Restyled by clang-format * ESP32: Add kDnss initialized event to re-establish binding table * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>

ESP32: Add kDnss initialized event to re-establish binding table

57a737c

github-actions bot added examples platform labels Mar 8, 2023

restyled-commits and others added 2 commits March 8, 2023 17:17

Restyled by clang-format

2ffdfb8

Merge branch 'master' into esp32/add_kDnss_initialize_event

487183f

pullapprove bot requested review from robszewczyk, saurabhst, selissia, sharadb-amazon, tcarmelveilleux, tecimovic, tehampson, turon, vijs, vivien-apple, woody-apple, xylophone21, younghak-hwang, yufengwangca and yunhanw-google March 8, 2023 11:06

pullapprove bot added the review - pending label Mar 8, 2023

bzbarsky-apple approved these changes Mar 8, 2023

View reviewed changes

examples/platform/esp32/ota/OTAHelper.cpp Outdated Show resolved Hide resolved

bzbarsky-apple mentioned this pull request Mar 8, 2023

[BUG] ESP32 sends message to the unique local address before it has route to the address and is able to reach the ULA #25570

Closed

abdulrehmanee12 and others added 3 commits March 9, 2023 16:42

ESP32: Add kDnss initialized event to re-establish binding table

da939b0

Restyled by clang-format

80f6aa6

Merge branch 'master' into esp32/add_kDnss_initialize_event

be76fe6

pullapprove bot added review - approved and removed review - pending labels Mar 9, 2023

Merge branch 'esp32/add_kDnss_initialize_event' of https://github.com…

4ab63d2

…/abdulrehmanee12/connectedhomeip into esp32/add_kDnss_initialize_event

Damian-Nordic approved these changes Mar 9, 2023

View reviewed changes

yufengwangca merged commit bdaf87f into project-chip:master Mar 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ESP32: Add kDnss initialized event to re-establish binding table #25563

ESP32: Add kDnss initialized event to re-establish binding table #25563

abdulrehmanee12 commented Mar 8, 2023

CLAassistant commented Mar 8, 2023 •

edited

Loading

github-actions bot commented Mar 8, 2023

github-actions bot commented Mar 8, 2023

github-actions bot commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

ESP32: Add kDnss initialized event to re-establish binding table #25563

ESP32: Add kDnss initialized event to re-establish binding table #25563

Conversation

abdulrehmanee12 commented Mar 8, 2023

CLAassistant commented Mar 8, 2023 • edited Loading

github-actions bot commented Mar 8, 2023

github-actions bot commented Mar 8, 2023

github-actions bot commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

CLAassistant commented Mar 8, 2023 •

edited

Loading