Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing MatterCastingServerBridge #25704

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

cliffamzn
Copy link
Contributor

The MatterCastingServerBridge is broken due to an API change in the subscriptionEstablishedCallback.

Tested by ensuring this builds successfully

The MatterCastingServerBridge is broken due to an [API change in the
subscriptionEstablishedCallback](project-chip@a8b42c1).

Tested by ensuring this builds successfully
@github-actions
Copy link

PR #25704: Size comparison from 346a817 to b75d015

Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
platform target config section 346a817 b75d015 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245969 20245969 0 0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804909 2804909 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 537360 537360 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468312 2468312 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1430956 1430956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1173580 1173580 0 0.0
bss 155557 155557 0 0.0
rodata 132620 132620 0 0.0
text 804636 804636 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1118796 1118796 0 0.0
bss 154713 154713 0 0.0
rodata 109436 109436 0 0.0
text 774008 774008 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1433600 1433600 0 0.0
bss 135297 135297 0 0.0
rodata 228672 228672 0 0.0
text 775556 775556 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153444 1153444 0 0.0
.bss 100076 100076 0 0.0
.data 852 852 0 0.0
.text 600540 600540 0 0.0
lock-app qpg6105+debug (read/write) 1120300 1120300 0 0.0
.bss 96468 96468 0 0.0
.data 864 864 0 0.0
.text 567400 567400 0 0.0

@yunhanw-google yunhanw-google merged commit da230ff into project-chip:master Mar 16, 2023
@cliffamzn cliffamzn deleted the casting_fix branch March 16, 2023 18:07
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
The MatterCastingServerBridge is broken due to an [API change in the
subscriptionEstablishedCallback](project-chip@a8b42c1).

Tested by ensuring this builds successfully
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants