Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger subscription re-establishment in MTRDevice when we see operational advertisements. #25716

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Trigger subscription re-establishment in MTRDevice when we see operational advertisements. #25716

merged 1 commit into from
Mar 16, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Seeing a new operational advertisement is a good signal it's worth trying to subscribe if we were waiting to do that.

@bzbarsky-apple bzbarsky-apple force-pushed the re-establish-subscription-on-operational-advertise branch from 4ff00ad to 9ebdcfc Compare March 16, 2023 18:36
@github-actions
Copy link

PR #25716: Size comparison from 82290df to 9ebdcfc

Full report (1 build for cc32xx)
platform target config section 82290df 9ebdcfc change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930289 930289 0 0.0
.debug_aranges 87392 87392 0 0.0
.debug_frame 300284 300284 0 0.0
.debug_info 20246023 20246023 0 0.0
.debug_line 2661031 2661031 0 0.0
.debug_loc 2804874 2804874 0 0.0
.debug_ranges 283152 283152 0 0.0
.debug_str 3027037 3027037 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380331 380331 0 0.0
.symtab 257376 257376 0 0.0
.text 537376 537376 0 0.0

@bzbarsky-apple
Trigger subscription re-establishment in MTRDevice when we see operat…
c4c8128 
…ional advertisements.

Seeing a new operational advertisement is a good signal it's worth trying to
subscribe if we were waiting to do that.
@bzbarsky-apple bzbarsky-apple force-pushed the re-establish-subscription-on-operational-advertise branch from 9ebdcfc to c4c8128 Compare March 16, 2023 20:54
@github-actions
Copy link

github-actions bot commented Mar 16, 2023 •
edited
Loading

PR #25716: Size comparison from 42a607c to c4c8128

Increases (4 builds for cc13x2_26x2, nrfconnect, psoc6)
platform target config section 42a607c c4c8128 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 172612 172620 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173616 1173632 16 0.0
text 804660 804664 4 0.0
nrf7002dk_nrf5340_cpuapp text 775580 775584 4 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22850260 22850261 1 0.0
Decreases (12 builds for bl602, cc13x2_26x2, cc32xx, cyw30739, efr32, nrfconnect, psoc6, qpg)
platform target config section 42a607c c4c8128 change % change
bl602 lighting-app bl602 .text 1028988 1028986 -2 -0.0
bl602+rpc .text 1059924 1059922 -2 -0.0
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 676987 676979 -8 -0.0
.text 589632 589624 -8 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 2024602 20246022 -2 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 593354 593346 -8 -0.0
.app_xip_area 464668 464660 -8 -0.0
efr32 lighting-app BRD4187C (read/write) 1014500 1014492 -8 -0.0
.text 838792 838784 -8 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 774036 774032 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27954322 27954320 -2 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27499483 27499482 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 23102432 23102431 -1 -0.0
qpg lighting-app qpg6105+debug (read/write) 1153492 1153484 -8 -0.0
.text 600588 600580 -8 -0.0
lock-app qpg6105+debug (read/write) 1120356 1120348 -8 -0.0
.text 567456 567448 -8 -0.0
Full report (34 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
platform target config section 42a607c c4c8128 change % change
bl602 lighting-app bl602 (read/write) 1356638 1356638 0 0.0
.bss 94842 94842 0 0.0
.data 9744 9744 0 0.0
.text 1028988 1028986 -2 -0.0
bl602+rpc (read/write) 1402062 1402062 0 0.0
.bss 102890 102890 0 0.0
.data 10136 10136 0 0.0
.text 1059924 1059922 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1188875 1188875 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70113 70113 0 0.0
.bss_psram 26048 26048 0 0.0
.comment 48 48 0 0.0
.data 4072 4072 0 0.0
.debug_abbrev 1556809 1556809 0 0.0
.debug_aranges 134600 134600 0 0.0
.debug_frame 493356 493356 0 0.0
.debug_info 40836374 40836374 0 0.0
.debug_line 5295278 5295278 0 0.0
.debug_loc 3427120 3427120 0 0.0
.debug_ranges 373504 373504 0 0.0
.debug_str 3588284 3588284 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 108064 108064 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 577244 577244 0 0.0
.symtab 174240 174240 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
959478 959478 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1279543 1279543 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78161 78161 0 0.0
.bss_psram 26320 26320 0 0.0
.comment 48 48 0 0.0
.data 4616 4616 0 0.0
.debug_abbrev 1708924 1708924 0 0.0
.debug_aranges 142928 142928 0 0.0
.debug_frame 521300 521300 0 0.0
.debug_info 45462981 45462981 0 0.0
.debug_line 5700621 5700621 0 0.0
.debug_loc 3625177 3625177 0 0.0
.debug_ranges 397504 397504 0 0.0
.debug_str 3992473 3992473 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122272 122272 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 638569 638569 0 0.0
.symtab 192736 192736 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1034820 1034820 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 682103 682103 0 0.0
(read/write) 169152 169152 0 0.0
.bss 80948 80948 0 0.0
.data 3352 3352 0 0.0
.rodata 88567 88567 0 0.0
.text 593220 593220 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 645415 645415 0 0.0
(read/write) 157616 157616 0 0.0
.bss 80148 80148 0 0.0
.data 3352 3352 0 0.0
.rodata 78439 78439 0 0.0
.text 566656 566656 0 0.0
lock-ftd LP_CC2652R7 (read only) 679271 679271 0 0.0
(read/write) 169448 169448 0 0.0
.bss 78500 78500 0 0.0
.data 3316 3316 0 0.0
.rodata 76815 76815 0 0.0
.text 601976 601976 0 0.0
lock-mtd LP_CC2652R7 (read only) 665235 665235 0 0.0
(read/write) 178644 178644 0 0.0
.bss 73660 73660 0 0.0
.data 3316 3316 0 0.0
.rodata 103619 103619 0 0.0
.text 561136 561136 0 0.0
pump-app LP_CC2652R7 (read only) 692051 692051 0 0.0
(read/write) 157412 157412 0 0.0
.bss 78476 78476 0 0.0
.data 3280 3280 0 0.0
.rodata 91003 91003 0 0.0
.text 600568 600568 0 0.0
pump-controller-app LP_CC2652R7 (read only) 676987 676979 -8 -0.0
(read/write) 172612 172620 8 0.0
.bss 78612 78612 0 0.0
.data 3304 3304 0 0.0
.rodata 86875 86875 0 0.0
.text 589632 589624 -8 -0.0
shell LP_CC2652R7 (read only) 673558 673558 0 0.0
(read/write) 179768 179768 0 0.0
.bss 83020 83020 0 0.0
.data 3348 3348 0 0.0
.rodata 85478 85478 0 0.0
.text 587768 587768 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930289 930289 0 0.0
.debug_aranges 87392 87392 0 0.0
.debug_frame 300284 300284 0 0.0
.debug_info 2024602 20246022 -2 -0.0
.debug_line 2661031 2661031 0 0.0
.debug_loc 2804874 2804874 0 0.0
.debug_ranges 283152 283152 0 0.0
.debug_str 3027037 3027037 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380331 380331 0 0.0
.symtab 257376 257376 0 0.0
.text 0 0 0 0.0
537376 537376 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 589106 589106 0 0.0
.app_xip_area 465716 465716 0 0.0
.bss 65832 65832 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 593354 593346 -8 -0.0
.app_xip_area 464668 464660 -8 -0.0
.bss 71120 71120 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 553614 553614 0 0.0
.app_xip_area 435816 435816 0 0.0
.bss 60280 60280 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1028340 1028340 0 0.0
.bss 179356 179356 0 0.0
.data 2132 2132 0 0.0
.text 846832 846832 0 0.0
BRD4187C (read/write) 1014500 1014492 -8 -0.0
.bss 148336 148336 0 0.0
.data 2776 2776 0 0.0
.text 838792 838784 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1080996 1080996 0 0.0
.bss 173772 173772 0 0.0
.data 2148 2148 0 0.0
.text 905056 905056 0 0.0
window-app BRD4187C (read/write) 1131244 1131244 0 0.0
.bss 132760 132760 0 0.0
.data 2668 2668 0 0.0
.text 971220 971220 0 0.0
k32w contact k32w0+release (read/write) 674192 674192 0 0.0
.bss 65532 65532 0 0.0
.data 2224 2224 0 0.0
.text 575036 575036 0 0.0
light k32w0+release (read/write) 673236 673236 0 0.0
.bss 65196 65196 0 0.0
.data 2212 2212 0 0.0
.text 574428 574428 0 0.0
lock k32w0+release (read/write) 627924 627924 0 0.0
.bss 63268 63268 0 0.0
.data 2136 2136 0 0.0
.text 547504 547504 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12188756 12188756 0 0.0
(read/write) 734648 734648 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 676584 676584 0 0.0
.dynamic 560 560 0 0.0
.got 15448 15448 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 589684 589684 0 0.0
.text 9855764 9855764 0 0.0
thermostat-no-ble arm64 (read only) 2523372 2523372 0 0.0
(read/write) 145240 145240 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77696 77696 0 0.0
.dynamic 560 560 0 0.0
.got 5368 5368 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150904 150904 0 0.0
.text 2110080 2110080 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468360 2468360 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1431004 1431004 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1173616 1173632 16 0.0
bss 155557 155557 0 0.0
rodata 132640 132640 0 0.0
text 804660 804664 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1433652 1433652 0 0.0
bss 135297 135297 0 0.0
rodata 228692 228692 0 0.0
text 775580 775584 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1118848 1118848 0 0.0
bss 154713 154713 0 0.0
rodata 109456 109456 0 0.0
text 774036 774032 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840840 840840 0 0.0
(read/write) 1763804 1763804 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1253727 1253727 0 0.0
.debug_aranges 111528 111528 0 0.0
.debug_frame 374912 374912 0 0.0
.debug_info 27954322 27954320 -2 -0.0
.debug_line 3796268 3796268 0 0.0
.debug_loc 3701947 3701947 0 0.0
.debug_ranges 364944 364944 0 0.0
.debug_str 3537037 3537037 0 0.0
.heap 840840 840840 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 583774 583774 0 0.0
.symtab 426800 426800 0 0.0
.text 1562912 1562912 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841648 841648 0 0.0
(read/write) 1704140 1704140 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189064 189064 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1239060 1239060 0 0.0
.debug_aranges 110760 110760 0 0.0
.debug_frame 377248 377248 0 0.0
.debug_info 27499483 27499482 -1 -0.0
.debug_line 3803767 3803767 0 0.0
.debug_loc 3685150 3685150 0 0.0
.debug_ranges 362880 362880 0 0.0
.debug_str 3524159 3524159 0 0.0
.heap 841648 841648 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 543080 543080 0 0.0
.symtab 411632 411632 0 0.0
.text 1504056 1504056 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849912 849912 0 0.0
(read/write) 1617196 1617196 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180968 180968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1074358 1074358 0 0.0
.debug_aranges 102968 102968 0 0.0
.debug_frame 347528 347528 0 0.0
.debug_info 22850260 22850261 1 0.0
.debug_line 3356258 3356258 0 0.0
.debug_loc 3360020 3360020 0 0.0
.debug_ranges 321416 321416 0 0.0
.debug_str 3322752 3322752 0 0.0
.heap 849912 849912 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 478139 478139 0 0.0
.symtab 379264 379264 0 0.0
.text 1425376 1425376 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 822136 822136 0 0.0
(read/write) 1674140 1674140 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208728 208728 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1076322 1076322 0 0.0
.debug_aranges 103368 103368 0 0.0
.debug_frame 349264 349264 0 0.0
.debug_info 23102432 23102431 -1 -0.0
.debug_line 3358628 3358628 0 0.0
.debug_loc 3384074 3384074 0 0.0
.debug_ranges 324016 324016 0 0.0
.debug_str 3341263 3341263 0 0.0
.heap 822136 822136 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 481602 481602 0 0.0
.symtab 381456 381456 0 0.0
.text 1454544 1454544 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153492 1153484 -8 -0.0
.bss 100076 100076 0 0.0
.data 852 852 0 0.0
.text 600588 600580 -8 -0.0
lock-app qpg6105+debug (read/write) 1120356 1120348 -8 -0.0
.bss 96468 96468 0 0.0
.data 864 864 0 0.0
.text 567456 567448 -8 -0.0

@yufengwangca yufengwangca merged commit 4e9bbb6 into project-chip:master Mar 16, 2023
@bzbarsky-apple bzbarsky-apple deleted the re-establish-subscription-on-operational-advertise branch March 17, 2023 00:33
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Trigger subscription re-establishment in MTRDevice when we see operat…
1f04f22 
…ional advertisements. (project-chip#25716)

Seeing a new operational advertisement is a good signal it's worth trying to
subscribe if we were waiting to do that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @yufengwangca @woody-apple