Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Bluetooth add advertising flags setup #25764

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

jlatusek
Copy link
Contributor

Problem

During pairing ble-wifi with the Tizen device running the lighting-app and the Linux running chip-tool, the Tizen device is not recognized as a proper BLE device.

Solution

Set proper advertising flags during advertising setup.

Testing

On the Linux device, run chip-tool:

./chip-tool pairing ble-wifi 0x01 <wifi> <pass> 20202021 3840

On the Tizen device run lighting-app:

app_launcher -s org.tizen.matter.example.lighting wifi true

@pullapprove pullapprove bot added review - pending and removed platform tizen For Tizen platform labels Mar 21, 2023
@jlatusek jlatusek changed the title Bluetooth add advertising flags setup [Tizen] Bluetooth add advertising flags setup Mar 21, 2023
@github-actions
Copy link

PR #25764: Size comparison from f994dae to 76862e2

Decreases (1 build for cc32xx)
platform target config section f994dae 76862e2 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20248023 20248022 -1 -0.0
Full report (1 build for cc32xx)
platform target config section f994dae 76862e2 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645601 645601 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930292 930292 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300320 300320 0 0.0
.debug_info 20248023 20248022 -1 -0.0
.debug_line 2661345 2661345 0 0.0
.debug_loc 2805489 2805489 0 0.0
.debug_ranges 283264 283264 0 0.0
.debug_str 3027174 3027174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380421 380421 0 0.0
.symtab 257408 257408 0 0.0
.text 537488 537488 0 0.0

@github-actions github-actions bot added platform tizen For Tizen platform labels Mar 21, 2023
@github-actions
Copy link

PR #25764: Size comparison from f994dae to c338306

Increases (1 build for qpg)
platform target config section f994dae c338306 change % change
qpg lock-app qpg6105+debug (read/write) 1121312 1121320 8 0.0
.text 568412 568420 8 0.0
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
platform target config section f994dae c338306 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645601 645601 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930292 930292 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300320 300320 0 0.0
.debug_info 20248023 20248023 0 0.0
.debug_line 2661345 2661345 0 0.0
.debug_loc 2805489 2805489 0 0.0
.debug_ranges 283264 283264 0 0.0
.debug_str 3027174 3027174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380421 380421 0 0.0
.symtab 257408 257408 0 0.0
.text 537488 537488 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468424 2468424 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1431068 1431068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1173744 1173744 0 0.0
bss 155557 155557 0 0.0
rodata 132640 132640 0 0.0
text 804780 804780 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1118960 1118960 0 0.0
bss 154713 154713 0 0.0
rodata 109456 109456 0 0.0
text 774152 774152 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1433764 1433764 0 0.0
bss 135297 135297 0 0.0
rodata 228692 228692 0 0.0
text 775696 775696 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1152768 1152768 0 0.0
.bss 96036 96036 0 0.0
.data 852 852 0 0.0
.text 599864 599864 0 0.0
lock-app qpg6105+debug (read/write) 1121312 1121320 8 0.0
.bss 91172 91172 0 0.0
.data 856 856 0 0.0
.text 568412 568420 8 0.0

@bzbarsky-apple bzbarsky-apple merged commit 5a0811e into project-chip:master Mar 21, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
* Add call bt_adapter_le_set_advertising_flags

* Add missing include files

* Reformat
@jlatusek jlatusek deleted the bluetooth-adv-flags-add branch January 15, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants