-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop generating a weakly typed enum for HardwareFaultEnum. #25806
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:strongly-typed-hardware-fault-enum
Mar 23, 2023
Merged
Stop generating a weakly typed enum for HardwareFaultEnum. #25806
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:strongly-typed-hardware-fault-enum
Mar 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
March 23, 2023 15:36
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
younghak-hwang
March 23, 2023 15:36
PR #25806: Size comparison from ed32443 to 460966e Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Damian-Nordic
approved these changes
Mar 23, 2023
bzbarsky-apple
force-pushed
the
strongly-typed-hardware-fault-enum
branch
from
March 23, 2023 17:48
460966e
to
d1d331e
Compare
PR #25806: Size comparison from bf14eb2 to d1d331e Increases (1 build for cc32xx)
Decreases (2 builds for cc32xx, qpg)
Full report (6 builds for cc32xx, nrfconnect, qpg)
|
andy31415
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.