Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop generating a weakly typed enum for HardwareFaultEnum. #25806

Conversation

bzbarsky-apple
Copy link
Contributor

No description provided.

@github-actions
Copy link

PR #25806: Size comparison from ed32443 to 460966e

Increases (1 build for cc32xx)
platform target config section ed32443 460966e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3027815 3028405 590 0.0
Decreases (1 build for cc32xx)
platform target config section ed32443 460966e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20239633 20229479 -10154 -0.1
Full report (1 build for cc32xx)
platform target config section ed32443 460966e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930286 930286 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300336 300336 0 0.0
.debug_info 20239633 20229479 -10154 -0.1
.debug_line 2661958 2661958 0 0.0
.debug_loc 2806731 2806731 0 0.0
.debug_ranges 283424 283424 0 0.0
.debug_str 3027815 3028405 590 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 537712 537712 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the strongly-typed-hardware-fault-enum branch from 460966e to d1d331e Compare March 23, 2023 17:48
@github-actions
Copy link

PR #25806: Size comparison from bf14eb2 to d1d331e

Increases (1 build for cc32xx)
platform target config section bf14eb2 d1d331e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3027815 3028405 590 0.0
Decreases (2 builds for cc32xx, qpg)
platform target config section bf14eb2 d1d331e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20239635 20229478 -10157 -0.1
qpg lock-app qpg6105+debug (read/write) 1121448 1121440 -8 -0.0
.text 568548 568540 -8 -0.0
Full report (6 builds for cc32xx, nrfconnect, qpg)
platform target config section bf14eb2 d1d331e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930286 930286 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300336 300336 0 0.0
.debug_info 20239635 20229478 -10157 -0.1
.debug_line 2661958 2661958 0 0.0
.debug_loc 2806731 2806731 0 0.0
.debug_ranges 283424 283424 0 0.0
.debug_str 3027815 3028405 590 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 537712 537712 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1174032 1174032 0 0.0
bss 155557 155557 0 0.0
rodata 132640 132640 0 0.0
text 805076 805076 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1119104 1119104 0 0.0
bss 154713 154713 0 0.0
rodata 109456 109456 0 0.0
text 774288 774288 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1434068 1434068 0 0.0
bss 135297 135297 0 0.0
rodata 228692 228692 0 0.0
text 775996 775996 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1152888 1152888 0 0.0
.bss 96036 96036 0 0.0
.data 852 852 0 0.0
.text 599984 599984 0 0.0
lock-app qpg6105+debug (read/write) 1121448 1121440 -8 -0.0
.bss 91172 91172 0 0.0
.data 856 856 0 0.0
.text 568548 568540 -8 -0.0

@andy31415 andy31415 merged commit 55552c8 into project-chip:master Mar 23, 2023
@bzbarsky-apple bzbarsky-apple deleted the strongly-typed-hardware-fault-enum branch March 23, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants