-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Fix enable_openthread_cli/uart build configuration #25835
[Silabs] Fix enable_openthread_cli/uart build configuration #25835
Conversation
…piled when if not needed mostly on the wifi builds
PR #25835: Size comparison from ec2ad41 to 4fa4413 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to replace the -1
magic value with something else. Either enum that is user-friendly or a bool with a default (I believe bool with default is clearer as "default/auto" in an enum seems to be ambigous)
I'll explain the situation here. The default args depend on other possible configurations. True for a standard thread build, False for a build with wifi-ncp.
This doesn't apply, user error on my part! |
This pr fix an issue where
enable_openthread_cli
default value was defining some values and adding multiple uart files to the build when it was not needed for wifi ncp builds.tested by building lighting app for thread and all 3 wifi ncp board supported and validating outputs