-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bouffalolab] Add data model/zap for Wi-Fi and Thread separately in lighting-app #25839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
March 27, 2023 01:50
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
March 27, 2023 01:50
wy-hh
force-pushed
the
lighting-app-data-model
branch
from
March 27, 2023 01:52
3491096
to
b5e92a2
Compare
PR #25839: Size comparison from ec2ad41 to b5e92a2 Increases above 0.2%:
Increases (6 builds for bl702, cc13x2_26x2, cc32xx, psoc6)
Decreases (7 builds for bl602, bl702, cc13x2_26x2, efr32, nrfconnect)
Full report (34 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
examples/lighting-app/bouffalolab/data_model/lighting-app-wifi.matter
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Mar 27, 2023
PR #25839: Size comparison from def9802 to 5a74f3f Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Mar 29, 2023
PR #25839: Size comparison from 3a80f8a to 94605c0 Full report (1 build for cc32xx)
|
PR #25839: Size comparison from ae17dc1 to c0f701b Full report (1 build for cc32xx)
|
PR #25839: Size comparison from ae17dc1 to 4c47b53 Full report (1 build for cc32xx)
|
wy-hh
force-pushed
the
lighting-app-data-model
branch
from
March 30, 2023 14:21
4c47b53
to
4be8d35
Compare
PR #25839: Size comparison from ae17dc1 to 4be8d35 Full report (1 build for cc32xx)
|
andy31415
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add data model/zap for Wi-Fi and Thread separately