-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QPG] Small fix to avoid calling KVS init twice #25917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
March 31, 2023 11:27
tima-q
changed the title
Small fix to avoid calling KVS init twice
[QPG] Small fix to avoid calling KVS init twice
Mar 31, 2023
PR #25917: Size comparison from ce0ddc0 to 09b12de Full report (2 builds for cc32xx, mbed)
|
andy31415
approved these changes
Mar 31, 2023
bzbarsky-apple
approved these changes
Mar 31, 2023
PR #25917: Size comparison from e4faf94 to a46616c Decreases (3 builds for bl602, bl702)
Full report (4 builds for bl602, bl702)
|
PR #25917: Size comparison from 14ffac0 to 451e140 Full report (1 build for cc32xx)
|
jmartinez-silabs
approved these changes
Apr 6, 2023
PR #25917: Size comparison from 6eded52 to 59abe07 Full report (1 build for cc32xx)
|
PR #25917: Size comparison from 03cb5e3 to 730c86c Increases (4 builds for cc13x2_26x2, k32w, nrfconnect, psoc6)
Decreases (4 builds for cc13x2_26x2, cyw30739, qpg)
Full report (25 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
turon
approved these changes
Apr 10, 2023
turon
approved these changes
Apr 10, 2023
PR #25917: Size comparison from ed5ebd2 to 1d21f9d Increases (5 builds for bl702, cyw30739, psoc6)
Decreases (3 builds for bl602, cyw30739)
Full report (19 builds for bl602, bl702, cyw30739, efr32, mbed, nrfconnect, psoc6)
|
PR #25917: Size comparison from b5d2e49 to 3bf056b Increases (1 build for psoc6)
Decreases (7 builds for bl602, bl702, psoc6, qpg)
Full report (17 builds for bl602, bl702, cyw30739, efr32, psoc6, qpg)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently KVS_Init is called in platform SDK and also in qpgConfig.cpp. This MR addresses the issue by removing the call from qpgConfig.