-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix crash when scan QR Code #25958
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
April 4, 2023 08:05
pullapprove
bot
requested review from
mhazley,
p0fi,
plauric,
tima-q and
tobiasgraf
July 13, 2023 08:36
pullapprove
bot
requested review from
andyg-apple,
aronrosenberg,
cecille,
mlepage-google,
tcarmelveilleux,
mkardous-silabs and
rcasallas-silabs
July 21, 2023 11:19
How this issue going? |
Unfortunately this was for a work POC and I've since been moved on to other things, so haven't been able to do any more proper investigation in to it. I believe my previous comment still stands, but ideally someone with some time needs to properly assess it. |
Add OtaProviderClientFragment to backstack as well
yunhanw-google
approved these changes
Jan 18, 2024
joonhaengHeo
approved these changes
Jan 18, 2024
PR #25958: Size comparison from b044b5e to a517f65 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time QR code scan, fragment Illegal state exception occurs, causing a crash.
It confirmed that the QR Code is read normally by preventing crash by adding Fragment
Analysis: if you didn't add it to the backstack, when you get to the QR scanning camera, it will scan the QR code, and then try to go back to the host fragment. But because the fragment wasn't on the backstack, it returns as null, and doesn't know where to return to.
Issue : #25957