Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CHEF DimmableLight be spec compliant (or at least pass linter) #26085

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

andy31415
Copy link
Contributor

Lint was failing like:

2023-04-13 08:45:17 ERROR   ERROR: Required attributes: EP0:AccessControl does not expose SubjectsPerAccessControlEntry(2) attribute at ./examples/chef/de
vices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter:1494:3
2023-04-13 08:45:17 ERROR   ERROR: Required attributes: EP0:AccessControl does not expose TargetsPerAccessControlEntry(3) attribute at ./examples/chef/dev
ices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter:1494:3
2023-04-13 08:45:17 ERROR   ERROR: Required attributes: EP0:AccessControl does not expose AccessControlEntriesPerFabric(4) attribute at ./examples/chef/de
vices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter:1494:3
2023-04-13 08:45:17 ERROR   ERROR: Required attributes: EP0:BasicInformation does not expose CapabilityMinima(19) attribute at ./examples/chef/devices/noi
p_rootnode_dimmablelight_bCwGYSDpoe.matter:1504:3
2023-04-13 08:45:17 ERROR   ERROR: Required attributes: EP0:LocalizationConfiguration does not expose ActiveLocale(0) attribute at ./examples/chef/devices
/noip_rootnode_dimmablelight_bCwGYSDpoe.matter:1543:3
2023-04-13 08:45:17 ERROR   ERROR: Required attributes: EP0:GeneralCommissioning does not expose SupportsConcurrentConnection(4) attribute at ./examples/c
hef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter:1557:3
2023-04-13 08:45:17 ERROR   ERROR: Required attributes: EP0:Switch does not expose NumberOfPositions(0) attribute at ./examples/chef/devices/noip_rootnode
_dimmablelight_bCwGYSDpoe.matter:1698:3
2023-04-13 08:45:17 ERROR   ERROR: Required attributes: EP0:Switch does not expose CurrentPosition(1) attribute at ./examples/chef/devices/noip_rootnode_d
immablelight_bCwGYSDpoe.matter:1698:3
2023-04-13 08:45:17 ERROR   Found 8 lint errors

fixed all these and removed the files from the lint exclusion.

@andy31415 andy31415 changed the title Fix chef dimmable light Make CHEF DimmableLight be spec compliant (or at least pass linter) Apr 13, 2023
@andy31415
Copy link
Contributor Author

fast track: example app changes without functionality deltas.

@github-actions
Copy link

PR #26085: Size comparison from 76eaffc to da52202

Increases (1 build for cc32xx)
platform target config section 76eaffc da52202 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20326060 20326061 1 0.0
Full report (1 build for cc32xx)
platform target config section 76eaffc da52202 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643081 643081 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87760 87760 0 0.0
.debug_frame 302028 302028 0 0.0
.debug_info 20326060 20326061 1 0.0
.debug_line 2687403 2687403 0 0.0
.debug_loc 2838361 2838361 0 0.0
.debug_ranges 288040 288040 0 0.0
.debug_str 3042379 3042379 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104393 104393 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377626 377626 0 0.0
.symtab 256832 256832 0 0.0
.text 536568 536568 0 0.0

@andy31415 andy31415 merged commit 3a79211 into project-chip:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants