-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dynamic Bridge example compilation #26129
Merged
andy31415
merged 9 commits into
project-chip:master
from
andy31415:fix_dyn_bridge_compile
Apr 17, 2023
Merged
Fix Dynamic Bridge example compilation #26129
andy31415
merged 9 commits into
project-chip:master
from
andy31415:fix_dyn_bridge_compile
Apr 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton and
jepenven-silabs
April 17, 2023 15:52
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
April 17, 2023 15:52
bzbarsky-apple
approved these changes
Apr 17, 2023
cecille
approved these changes
Apr 17, 2023
PR #26129: Size comparison from 5cdb0a5 to e7003ad Full report (1 build for cc32xx)
|
PR #26129: Size comparison from 5cdb0a5 to d62f5ae Decreases (1 build for qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26016 pulled in some std::string-backed global structs into the bridge app, which made it fail to compile since it was relying that
operator=
is defined for underlying data types and they are not (for std::string and chip::CharSpan).I switched things to a separate Assign operation that I overloaded for std::string/char-span compatibility.
I also added dynamic bridge to CI tests so that this app does not fail again.