Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dynamic Bridge example compilation #26129

Merged
merged 9 commits into from
Apr 17, 2023

Conversation

andy31415
Copy link
Contributor

#26016 pulled in some std::string-backed global structs into the bridge app, which made it fail to compile since it was relying that operator= is defined for underlying data types and they are not (for std::string and chip::CharSpan).

I switched things to a separate Assign operation that I overloaded for std::string/char-span compatibility.
I also added dynamic bridge to CI tests so that this app does not fail again.

src/lib/assign/ValueAssign.h Outdated Show resolved Hide resolved
@github-actions
Copy link

PR #26129: Size comparison from 5cdb0a5 to e7003ad

Full report (1 build for cc32xx)
platform target config section 5cdb0a5 e7003ad change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643249 643249 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87792 87792 0 0.0
.debug_frame 302140 302140 0 0.0
.debug_info 20328411 20328411 0 0.0
.debug_line 2687890 2687890 0 0.0
.debug_loc 2838930 2838930 0 0.0
.debug_ranges 288072 288072 0 0.0
.debug_str 3042155 3042155 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104401 104401 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377963 377963 0 0.0
.symtab 256976 256976 0 0.0
.text 536728 536728 0 0.0

@github-actions
Copy link

PR #26129: Size comparison from 5cdb0a5 to d62f5ae

Decreases (1 build for qpg)
platform target config section 5cdb0a5 d62f5ae change % change
qpg lighting-app qpg6105+debug (read/write) 1166704 1166696 -8 -0.0
.text 613804 613796 -8 -0.0
Full report (4 builds for cc32xx, mbed, qpg)
platform target config section 5cdb0a5 d62f5ae change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643249 643249 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87792 87792 0 0.0
.debug_frame 302140 302140 0 0.0
.debug_info 20328411 20328411 0 0.0
.debug_line 2687890 2687890 0 0.0
.debug_loc 2838930 2838930 0 0.0
.debug_ranges 288072 288072 0 0.0
.debug_str 3042155 3042155 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104401 104401 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377963 377963 0 0.0
.symtab 256976 256976 0 0.0
.text 536728 536728 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466336 2466336 0 0.0
.bss 215960 215960 0 0.0
.data 5888 5888 0 0.0
.text 1428980 1428980 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1166704 1166696 -8 -0.0
.bss 99308 99308 0 0.0
.data 856 856 0 0.0
.text 613804 613796 -8 -0.0
lock-app qpg6105+debug (read/write) 1136776 1136776 0 0.0
.bss 94452 94452 0 0.0
.data 860 860 0 0.0
.text 583872 583872 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants