-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LightSensorType to IlluminanceMeasurement for chef lighting example #26269
Merged
andy31415
merged 1 commit into
project-chip:master
from
tehampson:fix-chef-light-sensor-type
Apr 26, 2023
Merged
Add LightSensorType to IlluminanceMeasurement for chef lighting example #26269
andy31415
merged 1 commit into
project-chip:master
from
tehampson:fix-chef-light-sensor-type
Apr 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq and
bzbarsky-apple
April 26, 2023 17:36
pullapprove
bot
requested review from
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
April 26, 2023 17:36
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
April 26, 2023 17:36
bzbarsky-apple
approved these changes
Apr 26, 2023
PR #26269: Size comparison from 7bbb240 to e070a2b Increases (1 build for bl602)
Full report (12 builds for bl602, bl702, cc32xx, k32w, linux, qpg)
|
andy31415
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to test reading
LightSensorType
from aIlluminanceMeasurement
cluster in the chef example app