-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the kDNSServiceInterfaceIndexLocalOnly special-case on Darwin. #26287
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-localonly-special-case
May 1, 2023
Merged
Remove the kDNSServiceInterfaceIndexLocalOnly special-case on Darwin. #26287
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-localonly-special-case
May 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
April 27, 2023 22:50
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
April 27, 2023 22:50
PR #26287: Size comparison from e4d000d to f2654f7 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Interface kDNSServiceInterfaceIndexLocalOnly means the _registration_ is local-only, not that the registered host is localhost and has a loopback address. There can be local-only registrations for other hosts, and we need to do actual address resolution. To make this work right in our unit test setup, fix our registration code for the local-only case (which tests use) to register hostname -> IP mappings, which it was not doing before.
bzbarsky-apple
force-pushed
the
remove-localonly-special-case
branch
from
April 28, 2023 16:32
f2654f7
to
f075e83
Compare
PR #26287: Size comparison from 77d72a8 to f075e83 Full report (1 build for cc32xx)
|
vivien-apple
approved these changes
Apr 29, 2023
andy31415
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface kDNSServiceInterfaceIndexLocalOnly means the registration is local-only, not that the registered host is localhost and has a loopback address. There can be local-only registrations for other hosts, and we need to do actual address resolution.
To make this work right in our unit test setup, fix our registration code for the local-only case (which tests use) to register hostname -> IP mappings, which it was not doing before.